[SERVER-33710] Support readConcern snapshot with atClusterTime in cluster distinct command Created: 06/Mar/18 Updated: 29/Oct/23 Resolved: 08/Aug/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 4.1.2 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Misha Tyulenev | Assignee: | Cheahuychou Mao |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | ShardedTxn:GlobalSnapshot | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Sharding 2018-08-13 | ||||||||
| Participants: | |||||||||
| Description |
|
As part of this ticket:
Proposed implementation:
|
| Comments |
| Comment by Githook User [ 08/Aug/18 ] |
|
Author: {'username': 'cheahuychou', 'name': 'Cheahuychou Mao', 'email': 'cheahuychou.mao@mongodb.com'}Message: |
| Comment by Misha Tyulenev [ 01/Aug/18 ] |
|
lgtm |
| Comment by Esha Maharishi (Inactive) [ 01/Aug/18 ] |
|
Thanks, lgtm. |
| Comment by Jack Mulrow [ 01/Aug/18 ] |
No, we shouldn't have to do anything then.
Like we talked about offline, |
| Comment by Esha Maharishi (Inactive) [ 01/Aug/18 ] |
|
Looks good, two questions:
It seems like mongos's distinct already supports readConcern (as it should, since it's a read command). Is there something more to do?
It would be nice to avoid calling these in each command path. Is there a way we can place these calls above (in the service entry point) or below (in the ShardingTaskExecutor) the Command's run()? Will we try to reorganize the code to be able to do that under |
| Comment by Jack Mulrow [ 01/Aug/18 ] |
|
misha.tyulenev esha.maharishi, can you guys review the proposed implementation above? |