[SERVER-33756] Disable colors in benchmark output in logkeeper Created: 08/Mar/18 Updated: 29/Oct/23 Resolved: 26/Mar/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Testing Infrastructure |
| Affects Version/s: | 3.7.2 |
| Fix Version/s: | 3.7.4 |
| Type: | Bug | Priority: | Trivial - P5 |
| Reporter: | Robert Guo (Inactive) | Assignee: | Robert Guo (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Operating System: | ALL |
| Sprint: | TIG 2018-04-09 |
| Participants: |
| Description |
|
Turn off colors in benchmarks when running in evergreen. Logkeeper can not display them and shows raw ANSI escape codes instead. |
| Comments |
| Comment by Githook User [ 26/Mar/18 ] |
|
Author: {'email': 'robert.guo@10gen.com', 'name': 'Robert Guo', 'username': 'guoyr'}Message: |
| Comment by Robert Guo (Inactive) [ 26/Mar/18 ] |
|
I'm going to wait until Wednesday for the fix. Dominic Hamon from Google said he's already working on a PR. |
| Comment by Max Hirschhorn [ 26/Mar/18 ] |
|
robert.guo, can we just change resmoke.py to specify --benchmark_color=false when spawning the Benchmark executables rather than waiting to get the fix for the issue in google/benchmark itself? |
| Comment by Robert Guo (Inactive) [ 24/Mar/18 ] |
|
Thanks for pointing it out. As indicated in the PR from your comment, gbench should be doing the correct thing of using the TERM environment variable, but it's broken. I created a GH issue: https://github.com/google/benchmark/issues/559 This ticket will fix this problem in our vendored gbench. |
| Comment by Max Hirschhorn [ 21/Mar/18 ] |
|
I think we should turn off ANSI colors altogether when running Benchmark executables via resmoke.py. I'm honestly surprised it isn't detecting if stdout isn't a TTY and not using them automatically - https://github.com/google/benchmark/pull/126 suggests that's what it ought to be doing. |
| Comment by Robert Guo (Inactive) [ 09/Mar/18 ] |
|
max.hirschhorn yep. But if you cat out the file in a terminal, the colors will show up correctly. |
| Comment by Max Hirschhorn [ 08/Mar/18 ] |
|
robert.guo, does --log=file have a similar issue? |