[SERVER-33758] Remove logUserIds Created: 08/Mar/18  Updated: 29/Oct/23  Resolved: 26/Mar/18

Status: Closed
Project: Core Server
Component/s: Logging
Affects Version/s: 3.6.3
Fix Version/s: 3.7.4

Type: Improvement Priority: Trivial - P5
Reporter: Danny Hatcher (Inactive) Assignee: Benjamin Caimano (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Documented
is documented by DOCS-11527 Docs for SERVER-33758: Remove logUserIds Closed
Related
related to SERVER-10084 Logging infrastructure improvements f... Closed
Backwards Compatibility: Minor Change
Sprint: Platforms 2018-03-26
Participants:
Case:

 Description   

logUserIds appears to no longer work in the latest versions of MongoDB. As this functionality is now included in Auditing instead, we should remove it.



 Comments   
Comment by Benjamin Caimano (Inactive) [ 26/Mar/18 ]

Also cleaned up a mess of raw pointers that became unique pointers to become raw pointers again in the Encoder/Appender classes

Comment by Githook User [ 26/Mar/18 ]

Author:

{'email': 'ben.caimano@10gen.com', 'name': 'Ben Caimano'}

Message: SERVER-33758 Switch mongo::logger class use to unique_ptrs
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/5e0f695f77991eff4985b1417c44c25be64af0a6

Comment by Benjamin Caimano (Inactive) [ 26/Mar/18 ]

I'm pushing the supplemental commits today. (Making sure that everything is still hunky-dory with yet another evergreen patch.) I'd say they'll be in by the time we have the sprint planning meeting. Want me to close it when I push them?

Comment by Githook User [ 21/Mar/18 ]

Author:

{'email': 'ben.caimano@10gen.com', 'name': 'Ben Caimano'}

Message: SERVER-33758 Make mongo::logger classes use more unique_ptrs

Appenders and LogDomains now use unique ptrs internally and on
signature.
Branch: master
https://github.com/mongodb/mongo/commit/09d7a4c298d6b65ac2a1d028085df4168aea086d

Comment by Githook User [ 16/Mar/18 ]

Author:

{'email': 'ben.caimano@10gen.com', 'name': 'Ben Caimano'}

Message: SERVER-33758 Remove logUserIds

Removed unused `--logUserIds` flag, consolidated logger encoding
Branch: master
https://github.com/mongodb/mongo/commit/044c0d7d67e3b47e50282b7d9c4509313a6c8db0

Comment by Eric Milkie [ 08/Mar/18 ]

The logUserIds parameter still exists in the codebase, though, and it appears to at least still have the ability to add a "user:" field. Something in the code logic must have broken. We also have a jstest for it; log_user_basic.js

Comment by Kelsey Schubert [ 08/Mar/18 ]

It looks like this functionality was removed in 2.6 as part of SERVER-10084?

Generated at Thu Feb 08 04:34:29 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.