[SERVER-33780] Modularize initialization code in ShardingTest Created: 09/Mar/18  Updated: 16/Mar/18  Resolved: 16/Mar/18

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: 3.7.2
Fix Version/s: None

Type: Improvement Priority: Minor - P4
Reporter: Robert Guo (Inactive) Assignee: Robert Guo (Inactive)
Resolution: Won't Fix Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Sprint: TIG 2018-03-26
Participants:

 Description   

The initialization code for ShardingTest is 500 lines long. It can be split up into different components for mongos, shards, and config servers for better extensibility and readability.



 Comments   
Comment by Robert Guo (Inactive) [ 16/Mar/18 ]

After discussing this ticket with max.hirschhorn over the past few days, I am persuaded that the root cause of the ever-expanding ShardingTest initialization is the lack of any definition of variable, function, and class scoping for our shell test fixtures. (There's also a larger question of defining what testing code should go in the shell at all). As such, my proposal of refactoring the class using ES6 syntactical sugar to improve readability for primarily C++ developers will not solve the above issue.

Closing this ticket as won't fix.

Generated at Thu Feb 08 04:34:33 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.