[SERVER-33816] convert "explain" command to single-parse model Created: 12/Mar/18  Updated: 29/Oct/23  Resolved: 05/Apr/18

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 3.7.4

Type: Improvement Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-33881 Move old Command members into BasicCo... Closed
Backwards Compatibility: Fully Compatible
Sprint: Platforms 2018-03-12, Platforms 2018-03-26, Platforms 2018-04-09
Participants:

 Description   

explain is a strange command in that it's a Command and a Command user, and converting it to the new Command API opens the door to making Command API changes. Its 'parse' should parse the command to be explained..



 Comments   
Comment by Billy Donahue [ 05/Apr/18 ]



SERVER-33881 upgraded the authentication checks and this ticket's resolution fell out as a side effect.

Comment by Billy Donahue [ 26/Mar/18 ]

Mostly there, but a little more work in authentication has to happen.

Comment by Githook User [ 15/Mar/18 ]

Author:

{'email': 'billy.donahue@mongodb.com', 'name': 'Billy Donahue', 'username': 'BillyDonahue'}

Message: SERVER-33816 convert "explain" command to single-parse model

logAuthViolation
depurify Command::enhancedRun
lifetime issue with inner OpMsgRequest
parse() return needs explicit unique_ptr ctor
checkAuthForOperation elim
move commandCanRunHere check from parse() to run()
Branch: master
https://github.com/mongodb/mongo/commit/ff3674197c34af10b438bb99e3ac77571347660a

Generated at Thu Feb 08 04:34:39 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.