[SERVER-33828] Replace test early returns with tags Created: 12/Mar/18 Updated: 15/Mar/18 Resolved: 15/Mar/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Minor - P4 |
| Reporter: | Judah Schvimer | Assignee: | DO NOT USE - Backlog - Test Infrastructure Group (TIG) |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Participants: |
| Description |
|
An example is "startSetIfSupportsReadMajority". A "requires_read_concern_majority" tag would be clearer. |
| Comments |
| Comment by Spencer Brody (Inactive) [ 13/Mar/18 ] |
|
Sending back to TIG - if you don't want to do this feel free to close it as "Won't Fix" |
| Comment by Spencer Brody (Inactive) [ 13/Mar/18 ] |
|
Could we get the best of both worlds? i.e. could we use tags, but have resmoke determine which tags apply by speaking to an actual mongod rather than hardcoding the list? Either way, while I like this idea, I don't think it's a priority for the replication team right now. |
| Comment by Max Hirschhorn [ 13/Mar/18 ] |
|
My understanding of the benefit of the startSetIfSupportsReadMajority() function is to avoid hardcoding the list of storage engines that support read concern "majority" and relying on mongod itself to instruct the test whether it does or not. Using resmoke.py tags to express this concept is already possible and could be done by the Replication team if this change is desirable. I think it is worth calling out that we'd effectively be hardcoding this list in the build variant's test_flags expansion. |