[SERVER-33843] PeriodicKillSecondaries hook can run validate while a secondary is still applying operations Created: 13/Mar/18  Updated: 29/Oct/23  Resolved: 13/Mar/18

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 3.4.15, 3.6.4, 3.7.3

Type: Bug Priority: Major - P3
Reporter: Daniel Gottlieb (Inactive) Assignee: Daniel Gottlieb (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Related
is related to SERVER-24480 The Validate hook should run after Ch... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v3.6, v3.4
Sprint: Repl 2018-03-26
Participants:

 Description   

After PeriodicKillSecondaries does a pass of crashing the secondary, it runs validate followed by checking dbhashes.

However, the secondary upon coming back up and rejoining the replica set for validation, may still have oplog entries to apply. This can result in validation being run before a secondary has completed applying operations.

Checking the dbhashes waits for secondaries to have caught up before proceeding. If instead the snippet first checked dbhashes then validated, validating would see all collections in their end state for examining. This ordering would also match how the YAML configuration files order those two hooks.



 Comments   
Comment by Githook User [ 06/Apr/18 ]

Author:

{'email': 'daniel.gottlieb@mongodb.com', 'name': 'Daniel Gottlieb', 'username': 'dgottlieb'}

Message: SERVER-33843: Have periodic kill secondaries first do dbhash checks then validate collection.

(cherry picked from commit 2b2f4b65daa15ebc912c3e4db3d7768902b2f453)
Branch: v3.6
https://github.com/mongodb/mongo/commit/c6af9faf91d7911bdb29fc436f1480ffc6652c04

Comment by Githook User [ 25/Mar/18 ]

Author:

{'email': 'daniel.gottlieb@mongodb.com', 'name': 'Daniel Gottlieb', 'username': 'dgottlieb'}

Message: SERVER-33843: Have periodic kill secondaries first do dbhash checks then validate collection.

(cherry picked from commit 2b2f4b65daa15ebc912c3e4db3d7768902b2f453)
Branch: v3.4
https://github.com/mongodb/mongo/commit/b7e00e85cff5d18593ea21f6b87b116d370c98ca

Comment by Githook User [ 13/Mar/18 ]

Author:

{'email': 'daniel.gottlieb@mongodb.com', 'name': 'Daniel Gottlieb', 'username': 'dgottlieb'}

Message: SERVER-33843: Have periodic kill secondaries first do dbhash checks then validate collection.
Branch: master
https://github.com/mongodb/mongo/commit/2b2f4b65daa15ebc912c3e4db3d7768902b2f453

Generated at Thu Feb 08 04:34:44 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.