[SERVER-33850] Rename KillAllSessionsByPattern and ScopedKillAllSessionsByPatternImpersonator to not refer to session kill Created: 13/Mar/18 Updated: 12/Dec/23 |
|
| Status: | Backlog |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Tess Avitabile (Inactive) | Assignee: | Backlog - Cluster Scalability |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | MaxH, neweng, sharding-nyc-subteam2 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Assigned Teams: |
Cluster Scalability
|
| Sprint: | Sharding 2018-06-04, Sharding 2018-06-18, Sharding 2018-07-02, Sharding 2018-07-16, Sharding 2018-07-30, Sharding 2018-08-13 |
| Participants: | |
| Story Points: | 1 |
| Description |
|
After We should also take Matcher out of the SessionKiller namespace. |
| Comments |
| Comment by Tess Avitabile (Inactive) [ 10/Aug/18 ] |
|
Good question. I think it might be a good idea to split up the IDL into two files kill_sessions.idl and match_sessions.idl. KillAllSessionsUser, KillAllSessionsRole, and KillAllSessionsByPattern can be pulled out into match_sessions.idl and renamed to MatchAllSessionsUser, MatchAllSessionsRole, and MatchAllSessionsByPattern, respectively. kill_sessions.idl would depend on match_sessions.idl. The SessionKiller::Matcher could be pulled out into its own file and renamed just SessionMatcher. This way we could have a general notion of session matching that is using by both scanSessions() and session killing. |