[SERVER-33881] Move old Command members into BasicCommand Created: 14/Mar/18  Updated: 29/Oct/23  Resolved: 25/Apr/18

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 4.0.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-34596 remove Command::parseNs. Closed
is depended on by SERVER-33816 convert "explain" command to single-p... Closed
Backwards Compatibility: Fully Compatible
Sprint: Platforms 2018-03-26, Platforms 2018-04-09, Platforms 2018-04-23, Platforms 2018-05-07
Participants:

 Description   

Implementation of SERVER-33861 and SERVER-33816 clear the way for these members to be removed from Command and brought down into BasicCommand.

  • supportsWriteConcern
  • supportsReadConcern
  • allowsAfterClusterTime
  • Command::enhancedRun can now be removed
  • Command::explain can now be removed
  • Command::parse can be pure virtual


 Comments   
Comment by Billy Donahue [ 25/Apr/18 ]

parseNs is covered by SERVER-34596

Comment by Billy Donahue [ 20/Apr/18 ]

Still need to do parseNs

Comment by Githook User [ 05/Apr/18 ]

Author:

{'email': 'billy.donahue@mongodb.com', 'name': 'Billy Donahue', 'username': 'BillyDonahue'}

Message: SERVER-33881 move checkAuthorization to CommandInvocation

Explain commands already have a parsed _innerInvocation so they
can now use that for their auth check.
Branch: master
https://github.com/mongodb/mongo/commit/8b5a91133ea5ab272fed72b5d2ca0574899c270b

Comment by Billy Donahue [ 23/Mar/18 ]

https://mongodbcr.appspot.com/190730002/

Comment by Billy Donahue [ 20/Mar/18 ]

To move checkAuthentication into the CommandInvocation, we'll need to convert the meta-commands apply_ops_cmd and do_txn_command the way we converted explain_cmd.

Comment by Githook User [ 16/Mar/18 ]

Author:

{'email': 'billy.donahue@mongodb.com', 'name': 'Billy Donahue', 'username': 'BillyDonahue'}

Message: SERVER-33881 move members from Command to BasicCommand

BasicCommand::InvocationShim->BasicCommand::Invocation
Branch: master
https://github.com/mongodb/mongo/commit/f092c84d7fbba8220c8fecca51d0a582e90ee4a7

Comment by Billy Donahue [ 14/Mar/18 ]

Code https://mongodbcr.appspot.com/196000002/

Generated at Thu Feb 08 04:34:52 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.