[SERVER-33912] Remove --disable-warnings-as-errors from embedded builds Created: 15/Mar/18  Updated: 29/Oct/23  Resolved: 22/Aug/18

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 4.0.3, 4.1.3

Type: Bug Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: Andrew Morrow (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
depends on SERVER-29908 Libraries db/s/sharding and db/query/... Closed
depends on SERVER-34058 Should not call gethostuuid on platfo... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.0
Sprint: Platforms 2018-04-23, Platforms 2018-08-27
Participants:

 Description   

We currently are tripping an important warning on some embedded builders:

src/third_party/sqlite-amalgamation-3190300/sqlite3.c:29798:6: error: "gethostuuid() is disabled." [-Werror,-W#warnings]

We need to address that issue, and ensure that we can build without suppressing warnings.



 Comments   
Comment by Githook User [ 20/Sep/18 ]

Author:

{'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}

Message: SERVER-33912 Make warnings fatal for embedded builders

Also includes necessary feature flag and new clang warning suppressions

(cherry picked from commit a81a923c2c44d69a39a81ade66572fafedfa4f03)
Branch: v4.0
https://github.com/mongodb/mongo/commit/499f7c0f7dab2d3ed31cad84d3c96b5884436f5f

Comment by Githook User [ 22/Aug/18 ]

Author:

{'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}

Message: Revert "SERVER-33912 Make warnings fatal for embedded builders"

This reverts commit bce25d5e123843c0e594d6d743981099f236c983.
Branch: v4.0
https://github.com/mongodb/mongo/commit/d8810253bff426c58ee9040689302f8964053c9c

Comment by Githook User [ 22/Aug/18 ]

Author:

{'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}

Message: SERVER-33912 Make warnings fatal for embedded builders

Also includes necessary feature flag and new clang warning suppressions

(cherry picked from commit a81a923c2c44d69a39a81ade66572fafedfa4f03)
Branch: v4.0
https://github.com/mongodb/mongo/commit/bce25d5e123843c0e594d6d743981099f236c983

Comment by Githook User [ 22/Aug/18 ]

Author:

{'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}

Message: SERVER-33912 Make warnings fatal for embedded builders

Also includes necessary feature flag and new clang warning suppressions
Branch: master
https://github.com/mongodb/mongo/commit/a81a923c2c44d69a39a81ade66572fafedfa4f03

Generated at Thu Feb 08 04:34:58 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.