[SERVER-33917] Fix port_options.js to ensure mongod option parsing is occurring Created: 15/Mar/18  Updated: 29/Oct/23  Resolved: 16/Apr/18

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: 3.7.3
Fix Version/s: 4.0.0-rc0

Type: Bug Priority: Critical - P2
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Platforms 2018-03-26, Platforms 2018-04-09, Platforms 2018-04-23
Participants:
Linked BF Score: 44

 Description   

port_options.js isn't testing what it thinks it's testing.
It sends SIGTERM before mongod has installed its sighandlers, so mongod dies with that signal. But if mongod has installed its sighandlers, it shuts down normally from the SIGTERM and we should expect clean shutdown. Gabriel has suggested watching the mongod output stream to determine when it's installed its signal handlers, parsed its command options, and is ready to be killed.

----------
Originally read:

Fix port_options.js to deal with a child process dying with SIGKILL.
Currently it only expects SIGTERM. If a SIGKILL happens to the child for some reason, that's unexpected. But what we should do in that case is die, not fail an assert.

This addresses BF-7447, which is happening too often.



 Comments   
Comment by Githook User [ 16/Apr/18 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-33917 port_options.js ping mongod host instead of killing it
Branch: master
https://github.com/mongodb/mongo/commit/c476c42f6aea9aee212d109b3fc57ace01c696fc

Comment by Gregory McKeon (Inactive) [ 12/Apr/18 ]

billy.donahue can you update the ticket title/description as Gabriel mentioned?

Comment by Billy Donahue [ 06/Apr/18 ]

Ok thanks yes I think it’s probably very easy.

On Fri, Apr 6, 2018 at 5:18 PM Andrew Morrow (JIRA) <jira@mongodb.org>

Generated at Thu Feb 08 04:34:59 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.