[SERVER-33957] Varying venv paths frustrates full use of the scons cache Created: 17/Mar/18  Updated: 06/Dec/22  Resolved: 08/Aug/19

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: DO NOT USE - Backlog - Dev Tools
Resolution: Duplicate Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
duplicates SERVER-42702 $PYTHON should not be used in build s... Closed
Assigned Teams:
Developer Tools
Participants:

 Description   

These two contiguous builds used the cache, and there were no changes to anything but JS files, so basically everything should come from cache:

https://evergreen.mongodb.com/task/mongodb_mongo_master_enterprise_rhel_62_64_bit_compile_a2698593ede55dd3aaaedc882beec5aa30ff056e_18_03_16_15_15_24

https://evergreen.mongodb.com/task/mongodb_mongo_master_enterprise_rhel_62_64_bit_compile_fafb34dda41840937f062ab0a48fd784d63b8803_18_03_16_15_52_22

They don't share generated files though, because the venv paths differ:

https://evergreen.mongodb.com/task_log_raw/mongodb_mongo_master_enterprise_rhel_62_64_bit_compile_a2698593ede55dd3aaaedc882beec5aa30ff056e_18_03_16_15_15_24/0?type=T#L424

https://evergreen.mongodb.com/task_log_raw/mongodb_mongo_master_enterprise_rhel_62_64_bit_compile_fafb34dda41840937f062ab0a48fd784d63b8803_18_03_16_15_52_22/0?type=T#L425

It isn't too harmful, because the files they actually generate are identical, and SCons does notice this, but it would be even nicer if they didn't need to be regenerated and could come from the cache.



 Comments   
Comment by Mathew Robinson (Inactive) [ 08/Aug/19 ]

I'm closing this as a duplicate of SERVER-42702. The SCons feature mentioned in this ticket won't actually fix our IDL caching problem since SCons still uses the full virtualenv dir when it injects into the PATH. The solution in SERVER-42702 will make IDL files be reliably cached by SCons

Comment by Andrew Morrow (Inactive) [ 01/Nov/18 ]

I'm taking this out of sprint and out of the quick wins epic, and moving it to the "SCons Developer Productivity" epic. While we could probably fix this ourselves, it appears that upstream SCons is working on providing better integration with virtualenv: https://github.com/SCons/scons/pull/3216

We should wait for that work to land and see if using it just solves this issue for us.

Generated at Thu Feb 08 04:35:06 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.