[SERVER-33992] Mobile SE: Test validate functionality is doing the right thing Created: 19/Mar/18 Updated: 27/Oct/23 Resolved: 11/Jul/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Sulabh Mahajan | Assignee: | Sulabh Mahajan |
| Resolution: | Works as Designed | Votes: | 0 |
| Labels: | nonnyc, storage-engines | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Backport Requested: |
v4.0
|
||||||||||||||||||||||||
| Sprint: | Storage Non-NYC 2018-07-16 | ||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||
| Description |
|
Validate for Mobile SE is not tested yet. It might not be doing the right thing. This ticket tracks work needed to check if validate is actually finding corruption, and implementing as per size Storer's implementation. Also make sure that validate() gets retried if SQLite returns a busy error. |
| Comments |
| Comment by Sulabh Mahajan [ 11/Jul/18 ] |
|
I do not see any tests being impacted by validate() functionality anymore. Marking this ticket closed as all tasks tracked by this ticket are complete. |
| Comment by Sulabh Mahajan [ 11/Jul/18 ] |
|
I verified and validate() is doing the following:
Another point to consider is if we want to retry validate if a write conflict is encountered. I checked what WiredTiger is doing and it doesn't retry today. Validate in SQLite only does reads, so ideally shouldn't even get a database locked issue that translates to write conflict. I intend to keep the behaviour consistent with WiredTiger here. Effectively that means as far as implementation is concerned validate() seems to be doing the right thing and doesn't need any changes. |
| Comment by Sulabh Mahajan [ 20/Jun/18 ] |
|
|