[SERVER-34030] Format and lint Scons files Created: 21/Mar/18  Updated: 06/Dec/22  Resolved: 11/May/20

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Jonathan Abrahams Assignee: Backlog - Server Tooling and Methods (STM) (Inactive)
Resolution: Won't Fix Votes: 0
Labels: stm
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Gantt Dependency
has to be done after SERVER-23312 lint + format Python files Closed
Assigned Teams:
Server Tooling & Methods
Participants:

 Description   

We should Python linting + formatting on the SConstruct and SConscript files.



 Comments   
Comment by Ryan Timmons [ 11/May/20 ]

Closing as wont-fix to indicate that there is currently no intention of doing this. Please re-open if there is priority for this. Perhaps SDP could self-service this if necessary rather than having to go thru the STM prioritization queue.

Comment by Andrew Morrow (Inactive) [ 21/Mar/18 ]

Please note that it is a hard requirement from me that if we do this (which I do support) that it allow us to enforce vertical style for source and LIBDEPS lists, even in the degenerate case of single entry lists, and that it honor trailing comma style, without requiring annotations:

This style is more or less canonical: https://github.com/mongodb/mongo/blob/master/src/mongo/bson/mutable/SConscript#L19-L29

Generated at Thu Feb 08 04:35:20 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.