[SERVER-34032] Add tests of resuming a change stream after an "invalidate" change Created: 21/Mar/18  Updated: 29/Oct/23  Resolved: 30/Apr/18

Status: Closed
Project: Core Server
Component/s: Aggregation Framework
Affects Version/s: None
Fix Version/s: 4.0.0-rc0

Type: Task Priority: Major - P3
Reporter: Charlie Swanson Assignee: Ian Boros
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Query 2018-04-23, Query 2018-05-07
Participants:

 Description   

This is a gap in our test coverage. I think it should fail.



 Comments   
Comment by Githook User [ 02/May/18 ]

Author:

{'email': 'ian.boros@10gen.com', 'name': 'Ian Boros'}

Message: SERVER-34032 part 2: Relax tests which attempt to resume a change stream after invalidate
Branch: master
https://github.com/mongodb/mongo/commit/a54e19b6d2e4c027057c9c7bbb6fa76ec60364fc

Comment by Charlie Swanson [ 30/Apr/18 ]

spencer let's talk in person when you have a second.

Comment by Spencer Brody (Inactive) [ 30/Apr/18 ]

Woah, why are we allowing resuming after an 'invalidate'?  This is a major design change for changeStreams.  david.storch asya charlie.swanson

Comment by Githook User [ 30/Apr/18 ]

Author:

{'email': 'ian.boros@10gen.com', 'name': 'Ian Boros'}

Message: SERVER-34032 add tests for resuming using an "invalidate" resumeToken
Branch: master
https://github.com/mongodb/mongo/commit/3d43d9420c12c2f47d614fc6f2546cf80742817e

Comment by Charlie Swanson [ 09/Apr/18 ]

Until SERVER-34181 there will be no exposed cluster time. After that, I believe they could resume using that cluster time. This is all untested though, hence this ticket.

Change streams were not designed to be able to resume after an invalidation, so if implemented correctly I believe the current machinery will disallow resuming after an invalidation.

Comment by Asya Kamsky [ 09/Apr/18 ]

> I think it should fail.

But then how do they resume? (if it's on db, for instance)? Can they open a new change stream with cluster time from the last entry they had?

Generated at Thu Feb 08 04:35:20 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.