[SERVER-34107] Remove master-slave server status and isMaster code Created: 23/Mar/18 Updated: 29/Oct/23 Resolved: 26/Jun/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 4.7.0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Judah Schvimer | Assignee: | Grace Luong (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | former-quick-wins, master-slave, neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Sprint: | Repl 2020-06-29 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
This code is for when not "usingReplSets()": https://github.com/mongodb/mongo/blob/db787fb0a1627756a2a9204b2716ea4f4b9f3ea7/src/mongo/db/repl/replication_info.cpp#L93-L154 This appears to be for master slave only, since we check for isReplEnabled here: https://github.com/mongodb/mongo/blob/db787fb0a1627756a2a9204b2716ea4f4b9f3ea7/src/mongo/db/repl/replication_info.cpp#L165-L167 And for isMaster we pass in level=0: https://github.com/mongodb/mongo/blob/db787fb0a1627756a2a9204b2716ea4f4b9f3ea7/src/mongo/db/repl/replication_info.cpp#L349 grepping for usingReplSets checks may find other code to delete. It now seems redundant with "isReplEnabled" |
| Comments |
| Comment by Githook User [ 25/Jun/20 ] |
|
Author: {'name': 'Grace Luong', 'email': 'grace.luong@mongodb.com', 'username': 'graceluong'}Message: |