[SERVER-34113] Remove all support for snapshot reads outside of multi-document transactions Created: 23/Mar/18 Updated: 29/Oct/23 Resolved: 19/Jun/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Storage |
| Affects Version/s: | None |
| Fix Version/s: | 4.0.1, 4.1.1 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | James Wahlin | Assignee: | Xiangyu Yao (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | nyc | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||
| Backport Requested: |
v4.0
|
||||||||||||||||||||
| Sprint: | Storage NYC 2018-06-18, Storage NYC 2018-07-02 | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Description |
|
This is a follow on to |
| Comments |
| Comment by Githook User [ 10/Jul/18 ] |
|
Author: {'username': 'xy24', 'name': 'Xiangyu Yao', 'email': 'xiangyu.yao@mongodb.com'}Message: (cherry picked from commit 1871507cdbdd492abee785076203467d20e0e716) |
| Comment by Githook User [ 19/Jun/18 ] |
|
Author: {'username': 'xy24', 'name': 'Xiangyu Yao', 'email': 'xiangyu.yao@mongodb.com'}Message: |
| Comment by Tess Avitabile (Inactive) [ 12/Jun/18 ] |
|
Yes, we should replace inSnapshotReadOrMultiDocumentTransaction() with inMultiDocumentTransaction(). |
| Comment by Xiangyu Yao (Inactive) [ 12/Jun/18 ] |
|
tess.avitabile Do we still need to remove inSnapshotReadOrMultiDocumentTransaction()? or convert it to inMultiDocumentTransaction()? |
| Comment by Tess Avitabile (Inactive) [ 01/Jun/18 ] |
|
It might break some transactions tests when you remove this clause. DBDirectClient calls in transactions are succeeding because test commands are enabled. This is being worked on in |
| Comment by Louis Williams [ 15/May/18 ] |
|
|
| Comment by Tess Avitabile (Inactive) [ 08/May/18 ] |
|
We should also make sure that any command that is not supported in transactions does not claim to support snapshot read concern in supportsReadConcern. |
| Comment by Maria van Keulen [ 02/Apr/18 ] |
|
|
| Comment by Tess Avitabile (Inactive) [ 23/Mar/18 ] |
|
As part of this work, we should:
|