[SERVER-34155] Add clean shutdowns to kill_secondaries and kill_primaries passthroughs Created: 27/Mar/18 Updated: 29/Oct/23 Resolved: 17/May/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication, Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | 4.0.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Judah Schvimer | Assignee: | Robert Guo (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Sprint: | TIG 2018-05-07, TIG 2018-05-21 | ||||||||||||
| Participants: | |||||||||||||
| Story Points: | 2 | ||||||||||||
| Description |
|
Clean shutdowns leave the server in a different state then unclean shutdowns with respect to recover to a stable timestamp and are interesting by themselves. We do not have a lot of coverage around clean shutdowns and replication. |
| Comments |
| Comment by Githook User [ 17/May/18 ] |
|
Author: {'email': 'robert.guo@10gen.com', 'username': 'guoyr', 'name': 'Robert Guo'}Message: |
| Comment by Judah Schvimer [ 16/Apr/18 ] |
|
Thanks! |
| Comment by Samyukta Lanka [ 16/Apr/18 ] |
|
No, at the moment it only does unclean shutdowns. Also wanted to note that the kill_primaries suite also explicitly excludes tests that use fast count and other commands that use the WiredTiger size storer. |
| Comment by Judah Schvimer [ 16/Apr/18 ] |
|
samy.lanka and max.hirschhorn, does the kill_primaries hook ever do a clean shutdown followed by a startup with the data files intact? I think that is the only work left to do on this ticket. |
| Comment by Judah Schvimer [ 02/Apr/18 ] |
|
The kill_secondaries hook does a clean shutdown followed by a replica set start up with data files intact here: https://github.com/mongodb/mongo/blob/b64b512409dc84bd093d7266d5fc201177f85915/buildscripts/resmokelib/testing/hooks/periodic_kill_secondaries.py#L185-L194, so if kill_primaries hook in |
| Comment by Judah Schvimer [ 29/Mar/18 ] |
|
One goal of |
| Comment by Max Hirschhorn [ 29/Mar/18 ] |
|
judah.schvimer, I imagined doing this ticket in a similar manner to |
| Comment by Judah Schvimer [ 29/Mar/18 ] |
|
I did not mean for |
| Comment by Max Hirschhorn [ 29/Mar/18 ] |
Maybe? It isn't clear to me if you meant for |
| Comment by Judah Schvimer [ 27/Mar/18 ] |
|
Would that be a duplicate of |
| Comment by Max Hirschhorn [ 27/Mar/18 ] |
How about we repurpose this ticket to add a clean shutdown primary version of the stepdown suite like we're doing with the kill primary version? |
| Comment by Judah Schvimer [ 27/Mar/18 ] |
|
I guess we do already restart the fixture with data files intact here. My original thought was to alternate clean and unclean shutdowns randomly, though I guess we're doing both after every 30 seconds anyways now that I look closer. I'm definitely interested in the kill_primaries hook to also have clean shutdowns that restart the node with data files intact, in addition to hard kills, but that's under development so maybe this ticket is a "works as designed". |
| Comment by Max Hirschhorn [ 27/Mar/18 ] |
|
judah.schvimer, could you elaborate on when you'd want the secondary to be cleanly shut down in the replica_sets_kill_secondaries_jscore_passthrough.yml test suite? My understanding is that sending a SIGKILL at this point in the hook is done to try and kill the secondary part-way into applying a batch. |