[SERVER-34196] OpObserver::onRenameCollection() dropTarget boolean argument is redundant Created: 29/Mar/18  Updated: 29/Oct/23  Resolved: 30/Mar/18

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 3.7.4

Type: Improvement Priority: Minor - P4
Reporter: Benety Goh Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
Related
is related to SERVER-33956 A sequence of rename and create colle... Closed
Backwards Compatibility: Fully Compatible
Participants:
Linked BF Score: 89

 Description   

With UUIDs enabled by default, the dropped target collection UUID passed to the OpObserver::onRenameCollection() function is sufficient to infer the dropTarget state of the collection rename.

This change should not be back ported to 3.6 because we may still need to generate renameCollection oplog entries with a boolean dropTarget field in the absence of UUIDs.



 Comments   
Comment by Githook User [ 30/Mar/18 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-34196 omit dropTarget field from generated oplog entry when it is false
Branch: master
https://github.com/mongodb/mongo/commit/f1bb8e1389d6aa458e5100f3eb753b80b1a4e4e7

Comment by Githook User [ 30/Mar/18 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-34196 remove redundant dropTarget boolean argument from OpObserver::onRenameCollection
Branch: master
https://github.com/mongodb/mongo/commit/149f69b84042ff4cbdc53559c746feb8f948273e

Comment by Benety Goh [ 29/Mar/18 ]

This improvement was suggested during a review of the work in SERVER-33956

Generated at Thu Feb 08 04:35:52 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.