[SERVER-34285] [post-branch] Remove FCV 3.6 switch logic in movePrimary Created: 03/Apr/18  Updated: 29/Oct/23  Resolved: 15/Jun/18

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: 3.7.3
Fix Version/s: 4.1.1

Type: Task Priority: Major - P3
Reporter: Blake Oler Assignee: Blake Oler
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-35116 Enumerate and remove Sharding-related... Closed
Backwards Compatibility: Fully Compatible
Sprint: Sharding 2018-06-18
Participants:

 Description   

Multiple checks exist to ensure that the right FCV is being used. Once the major version 4.0 releases, we can remove these checks. As of 4/3/2018, these files use FCV logic checks:

configsvr_move_primary_command.cpp
sharding_catalog_manager_database_operations.cpp
move_primary_source_manager.cpp

Additionally, these tests check both the FCV 3.6 and FCV 4.0 code paths. Once the FCV 3.6 code is removed, the FCV 3.6 portions of these tests can be removed as well.

moveprimary-replset.js
movePrimary1.js
move_primary_basic.js
move_primary_clone_test.js

Also consider a rename (or deletion) of move_primary_fcv_40.js, without losing the specific DatabaseVersion checks (add them somewhere else, maybe).

As a last look, consider deleting _buildMoveLogEntry in configsvr_move_primary_command. We may not need it after everything else is gone.



 Comments   
Comment by Githook User [ 15/Jun/18 ]

Author:

{'username': 'BlakeIsBlake', 'name': 'Blake Oler', 'email': 'blake.oler@mongodb.com'}

Message: SERVER-34285 Remove FCV 3.6 switch logic in movePrimary
Branch: master
https://github.com/mongodb/mongo/commit/7a46f808c6e24613ba08cdd7260877122813d59c

Generated at Thu Feb 08 04:36:09 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.