[SERVER-34338] find explain in legacy query path on mongos does not retry on StaleShardVersion Created: 05/Apr/18 Updated: 29/Oct/23 Resolved: 01/Jun/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | 3.6.3, 3.7.3 |
| Fix Version/s: | 4.0.0, 4.1.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Esha Maharishi (Inactive) | Assignee: | Esha Maharishi (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||||||||||
| Backport Requested: |
v4.0
|
||||||||||||||||||||||||||||
| Steps To Reproduce: |
|
||||||||||||||||||||||||||||
| Sprint: | Sharding 2018-05-21, Sharding 2018-06-04 | ||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||
| Description |
|
This is a regression introduce by this line in this commit on 3.6, where we pulled the StaleShardVersion handling in mongos up from scatterGather() to strategy::runCommand(). There are no tests that run "find explain" (which is the only thing that goes through the legacy query path that does not internally handle StaleShardVersion) from a stale mongos with --shellReadMode=legacy, so this was not caught. See attached repro, which should be run with --shellReadMode=legacy to make the "find explain" go through the legacy query path on mongos. |
| Comments |
| Comment by Githook User [ 01/Jun/18 ] |
|
Author: {'username': 'EshaMaharishi', 'name': 'Esha Maharishi', 'email': 'esha.maharishi@mongodb.com'}Message: |
| Comment by Githook User [ 01/Jun/18 ] |
|
Author: {'username': 'EshaMaharishi', 'name': 'Esha Maharishi', 'email': 'esha.maharishi@mongodb.com'}Message: |
| Comment by Githook User [ 01/Jun/18 ] |
|
Author: {'username': 'EshaMaharishi', 'name': 'Esha Maharishi', 'email': 'esha.maharishi@mongodb.com'}Message: (cherry picked from commit 3e31679dfa6d85ebe48855582304c8cb7a635b0d) |
| Comment by Githook User [ 01/Jun/18 ] |
|
Author: {'username': 'EshaMaharishi', 'name': 'Esha Maharishi', 'email': 'esha.maharishi@mongodb.com'}Message: |
| Comment by Charlie Swanson [ 25/Apr/18 ] |
|
Linking to SERVER-29449, only because I believe this is an additional symptom of separate code paths for explain/non-explain in the find command. |