[SERVER-34477] Coverity analysis defect 103475: Invalid iterator comparison Created: 13/Apr/18  Updated: 29/Oct/23  Resolved: 17/Apr/18

Status: Closed
Project: Core Server
Component/s: Security
Affects Version/s: None
Fix Version/s: 3.4.15, 3.6.5, 3.7.5

Type: Bug Priority: Major - P3
Reporter: Coverity Collector User Assignee: Sara Golemon
Resolution: Fixed Votes: 0
Labels: coverity
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Gantt Dependency
has to be done after SERVER-34237 Expose means for shell to disable TLS... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v3.6, v3.4
Sprint: Platforms 2018-04-23
Participants:

 Description   

Iterators that point to different containers are compared

Defect 103475 (STATIC_C)
Checker MISMATCHED_ITERATOR (subcategory mismatched_comparison)
File: /src/mongo/util/net/ssl_options.cpp
Function mongo::<unnamed>::storeDisabledProtocols(const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> &, mongo::<unnamed>::DisabledProtocolsMode)
/src/mongo/util/net/ssl_options.cpp, line: 111
"validNoConfigs.find(token)" returns an iterator for "validNoConfigs".

                mappedToken = validNoConfigs.find(token);

/src/mongo/util/net/ssl_options.cpp, line: 111
Assigning: "mappedToken" = "validNoConfigs.find(token)".

                mappedToken = validNoConfigs.find(token);

/src/mongo/util/net/ssl_options.cpp, line: 114
"validConfigs.end()" returns an iterator for "validConfigs".

            if (mappedToken != validConfigs.end()) {

/src/mongo/util/net/ssl_options.cpp, line: 114
Comparing "mappedToken" from "validNoConfigs" to "validConfigs.end()" from "validConfigs".

            if (mappedToken != validConfigs.end()) {



 Comments   
Comment by Githook User [ 04/May/18 ]

Author:

{'email': 'sara.golemon@mongodb.com', 'name': 'Sara Golemon', 'username': 'sgolemon'}

Message: SERVER-34477 Do not mix iterators from different maps

(cherry picked from commit 88385c06825a73a3875bcdecf2af650c012b48f1)
(cherry picked from commit 7c6a15fecd95ff32cf17f8d9abad81b730c5773c)
Branch: v3.4
https://github.com/mongodb/mongo/commit/52e5b5fbaa3a2a5b1a217f5e647b5061817475f9

Comment by Githook User [ 04/May/18 ]

Author:

{'email': 'sara.golemon@mongodb.com', 'name': 'Sara Golemon', 'username': 'sgolemon'}

Message: SERVER-34477 Do not mix iterators from different maps

(cherry picked from commit 88385c06825a73a3875bcdecf2af650c012b48f1)
Branch: v3.6
https://github.com/mongodb/mongo/commit/7c6a15fecd95ff32cf17f8d9abad81b730c5773c

Comment by Githook User [ 17/Apr/18 ]

Author:

{'name': 'Sara Golemon', 'email': 'sara.golemon@mongodb.com', 'username': 'sgolemon'}

Message: SERVER-34477 Do not mix iterators from different maps
Branch: master
https://github.com/mongodb/mongo/commit/88385c06825a73a3875bcdecf2af650c012b48f1

Generated at Thu Feb 08 04:36:49 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.