[SERVER-34552] clusterAggregate does not handle the case when aggregate fails due to SSV or snapshot errors Created: 18/Apr/18  Updated: 29/Oct/23  Resolved: 10/May/18

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 4.0.0-rc0

Type: Bug Priority: Major - P3
Reporter: Misha Tyulenev Assignee: Nicholas Zolnierz
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Related
related to SERVER-34695 Move aggregation retry logic to comma... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Query 2018-05-21
Participants:
Linked BF Score: 56

 Description   

This invariant will fail
The try catch block https://github.com/mongodb/mongo/blob/r3.7.5/src/mongo/s/commands/cluster_aggregate.cpp#L455-L509 does not handle the case that it will exhaust the attempts so it returns empty results.

When its fixed the cluster_aggregate_test needs to get updated as well to include a currently disabled test.



 Comments   
Comment by Misha Tyulenev [ 04/May/18 ]

nicholas.zolnierz Could you please enable the test https://github.com/mongodb/mongo/blob/master/src/mongo/s/commands/cluster_aggregate_test.cpp#L223

 - it was disabled pending the fix. Once its done the bug can be closed.

Comment by Nicholas Zolnierz [ 04/May/18 ]

Cluster aggregate is no longer handling SSV retries, instead throwing the assertions up to the command layer which correctly handles exhausting the retry count.

Comment by Ian Whalen (Inactive) [ 04/May/18 ]

Assigning to Nick to confirm as Gone Away once SRVER-34695 is resolved.

Comment by Nicholas Zolnierz [ 27/Apr/18 ]

Will likely be fixed by the linked SERVER-34695.

Comment by Kaloian Manassiev [ 27/Apr/18 ]

Passing on the query team who owns aggregation. This was found via unit-tests for Global Snapshot Reads, but is a legitimate bug. CC nicholas.zolnierz

Generated at Thu Feb 08 04:37:03 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.