[SERVER-34597] shardedcluster.py does not wait correctly on shards initialization Created: 20/Apr/18 Updated: 29/Oct/23 Resolved: 15/Mar/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding, Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | 5.0.0, 4.4.11, 4.4.10 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Misha Tyulenev | Assignee: | Kshitij Gupta |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | sharding-wfbf-day | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||
| Backport Requested: |
v5.0, v4.9, v4.4
|
||||||||||||||||||||
| Sprint: | Sharding 2020-09-07, Sharding 2021-01-11, Sharding 2021-01-25, Sharding 2021-02-22, Sharding 2021-03-08, Sharding 2021-03-22 | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Linked BF Score: | 129 | ||||||||||||||||||||
| Description |
|
This test
will fail if run as
when
This happens because the https://github.com/mongodb/mongo/blob/r3.7.5/buildscripts/resmokelib/testing/fixtures/replicaset.py#L214 does not wait for sharding initialization to be completed. The error usually manifests as the following output in a log:
|
| Comments |
| Comment by Githook User [ 08/Oct/21 ] |
|
Author: {'name': 'Kshitij Gupta', 'email': 'kshitij.gupta@mongodb.com', 'username': 'kshitijng'}Message: (cherry picked from commit 1f84ef5e4ca8b5be22d038ea2a6cc3e5e6863194) |
| Comment by Githook User [ 10/Mar/21 ] |
|
Author: {'name': 'Kshitij Gupta', 'email': 'kshitij.gupta@mongodb.com', 'username': 'kshitijng'}Message: |
| Comment by Lamont Nelson [ 13/Nov/20 ] |
|
Code review: https://mongodbcr.appspot.com/726130001 |
| Comment by Misha Tyulenev [ 24/Apr/20 ] |
|
The issue has reoccured in BF-16730 |
| Comment by Lamont Nelson [ 12/Dec/19 ] |
|
The error was not duplicated with the latest code. |
| Comment by Lamont Nelson [ 12/Dec/19 ] |
|
I tested this with the latest code, and the error does not occur. |
| Comment by Max Hirschhorn [ 27/Apr/18 ] |
|
kaloian.manassiev, to put it another way, there should be a single code review that simultaneously updates the mongo shell's ShardingTest and resmoke.py's ShardedClusterFixture to use the "getShardVersion" command (or whatever the mechanism is going to be to wait for the sharding state to have been initialized). |
| Comment by Kaloian Manassiev [ 27/Apr/18 ] |
|
Assigning to Esha to figure out with Max about whether we should be copying the changes that are made to the fixture or whether TIG is waiting for us to make changes that they would emulate. |
| Comment by Max Hirschhorn [ 20/Apr/18 ] |
|
We should make the equivalent changes to the mongo shell's ShardingTest if we are going to update resmoke.py's ShardedClusterFixture. |