[SERVER-34848] BatchedCommandRequest.cpp has an INVOKE macro Created: 04/May/18  Updated: 29/Oct/23  Resolved: 04/May/18

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.0.0-rc0

Type: Improvement Priority: Trivial - P5
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Platforms 2018-05-07
Participants:

 Description   

Annoying INVOKE macro in BatchedCommandRequest pseudovariant.

This is just

std::variant::visit

and could be better written without a macro.

INVOKE is a name that appears in the standard and is a bit of a confusion risk.

Fix is trivial.

 



 Comments   
Comment by Benety Goh [ 04/May/18 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-34848 fix lint
Branch: master
https://github.com/mongodb/mongo/commit/2d718fae1d2520284000bd2613df30e490aee8ab

Comment by Benety Goh [ 04/May/18 ]

Author:

{'email': 'billy.donahue@mongodb.com', 'name': 'Billy Donahue ', 'username': 'BillyDonahue'}

Message: SERVER-34848 Replace INVOKE macro with BatchedCommandRequest::_visit
Branch: master
https://github.com/mongodb/mongo/commit/f0f8b61516e8355df6907820dead4be0b26cf07f

Comment by Billy Donahue [ 04/May/18 ]

code review url https://mongodbcr.appspot.com/201420002/

Generated at Thu Feb 08 04:38:03 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.