[SERVER-34928] Address new GCC8 -Wparentheses warnings Created: 10/May/18 Updated: 29/Oct/23 Resolved: 15/May/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Build |
| Affects Version/s: | None |
| Fix Version/s: | 4.0.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Mathias Stearn | Assignee: | Mathias Stearn |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Platforms 2018-05-21 | ||||||||
| Participants: | |||||||||
| Description |
|
We don't want to disable this because it is a valuable warning. It is the one that warns on if (x = 5) for example. This warning only trips in third_party headers so I plan to use the same suppression style as boost added: https://github.com/boostorg/mpl/blob/3c1910797cf2a9e6f18a0a929bec95837accfb9e/include/boost/mpl/assert.hpp#L187-L206 |
| Comments |
| Comment by Githook User [ 14/May/18 ] |
|
Author: {'name': 'Mathias Stearn', 'email': 'mathias@10gen.com', 'username': 'RedBeard0531'}Message: This is a manual cherry-pick of changes already made upstream in boost and WT. |