[SERVER-34958] Remove unused condition variable in Session Created: 11/May/18  Updated: 29/Oct/23  Resolved: 05/Jun/18

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.1.1

Type: Improvement Priority: Trivial - P5
Reporter: Ian Boros Assignee: Jinny Byun
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Repl 2018-06-04, Repl 2018-06-18
Participants:

 Description   

While investigating BFs we noticed that the condition variable Session::_commitcv is notified but never waited on. Apparently it was added by accident.

https://github.com/mongodb/mongo/blob/master/src/mongo/db/session.cpp#L1014

https://github.com/mongodb/mongo/blob/ecf8ad987548705e773d23d5ddc3973cbc1ea7e5/src/mongo/db/session.h#L455

 



 Comments   
Comment by Githook User [ 05/Jun/18 ]

Author:

{'username': 'jinichu', 'name': 'jinichu', 'email': 'jinnybyun@gmail.com'}

Message: SERVER-34958 Deleted unused condition variable Session::_commitcv
Branch: master
https://github.com/mongodb/mongo/commit/5c752f0229db456d5c8b8a15674724d79fb5424a

Generated at Thu Feb 08 04:38:23 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.