[SERVER-34976] clear the "needing size adjustment" set at the beginning of replication rollback Created: 14/May/18 Updated: 29/Oct/23 Resolved: 12/Jun/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 4.0.0-rc6, 4.1.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Judah Schvimer | Assignee: | Judah Schvimer |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||||||||||||||||||
| Backport Requested: |
v4.0
|
||||||||||||||||||||||||||||||||||||
| Sprint: | Repl 2018-06-04, Repl 2018-06-18 | ||||||||||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||||||||||
| Linked BF Score: | 65 | ||||||||||||||||||||||||||||||||||||
| Description |
|
One problem we've noted is that this call to mark collections as needing size adjustment is not gated on being in storage recovery, which is what it's meant for. This means any collections that are created are marked as needing size adjustment, even if later writes would ensure they have a non-zero size at the stable timestamp when we enter rollback. To fix this, we can clear the "needing size adjustment" set at the beginning of replication rollback. |
| Comments |
| Comment by Githook User [ 12/Jun/18 ] | |||||||||||||||||||||||||||||||||||||||||||
|
Author: {'username': 'judahschvimer', 'name': 'Judah Schvimer', 'email': 'judah@mongodb.com'}Message: (cherry picked from commit 8b698cac2d19f0fec502db10501e7059a10d2897) | |||||||||||||||||||||||||||||||||||||||||||
| Comment by Githook User [ 12/Jun/18 ] | |||||||||||||||||||||||||||||||||||||||||||
|
Author: {'username': 'judahschvimer', 'name': 'Judah Schvimer', 'email': 'judah@mongodb.com'}Message: | |||||||||||||||||||||||||||||||||||||||||||
| Comment by Siyuan Zhou [ 01/Jun/18 ] | |||||||||||||||||||||||||||||||||||||||||||
|
Fast count is disabled on master and 4.0 in | |||||||||||||||||||||||||||||||||||||||||||
| Comment by Judah Schvimer [ 18/May/18 ] | |||||||||||||||||||||||||||||||||||||||||||
|
This is a problem even without capped collections. Repro:
|