[SERVER-35056] Flush ready callbacks on NetworkInterfaceTL shutdown Created: 17/May/18 Updated: 29/Oct/23 Resolved: 30/Jul/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.0.2, 4.1.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Jonathan Reams | Assignee: | Benjamin Caimano (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Backport Requested: |
v4.0
|
||||||||
| Sprint: | Platforms 2018-05-21, Platforms 2018-06-04, Platforms 2018-06-18, Platforms 2018-07-02, Platforms 2018-07-16, Platforms 2018-07-30 | ||||||||
| Participants: | |||||||||
| Linked BF Score: | 50 | ||||||||
| Description |
|
When shutting down NetworkInterfaceTL, we must make sure to flush any ready callbacks on the reactor after stopping it, otherwise outstanding errors will not get propagated and we will leak outstanding command states on shutdown. |
| Comments |
| Comment by Githook User [ 17/Aug/18 ] |
|
Author: {'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}Message: Squashed from 3 commits:
This API invites subtle race conditions. So just remove it, and (cherry picked from commit 2338f365430d7f395faf73bff6c64def505da1b3)
(cherry picked from commit b49a27b359b17cd1b1560134b89527b78db565cc)
(cherry picked from commit 5e0545d3625dc85d16f5f021896f61d3a21e2333) |
| Comment by Benjamin Caimano (Inactive) [ 30/Jul/18 ] |
|
Closing this out, seems like it's working. |
| Comment by Githook User [ 29/Jul/18 ] |
|
Author: {'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}Message: |
| Comment by Ian Whalen (Inactive) [ 28/Jul/18 ] |
|
I see acm redbeard0531 adam.martin and mark.benvenuto all listed as reviewers who have not LGTMd this yet. Are you all waiting on more edits from Ben? Or is this OK for Ben to push? |
| Comment by Andrew Morrow (Inactive) [ 19/Jul/18 ] |
|
I've pinged the review. |
| Comment by Benjamin Caimano (Inactive) [ 19/Jul/18 ] |
|
I've actually had the green patch'd fix up for code review for a week or two now. I've pinged it a few times to no effect. Apologies on the delay, ian.whalen, I'll try to get movement in stand up today. |
| Comment by Ian Whalen (Inactive) [ 19/Jul/18 ] |
|
ben.caimano acm this has now into it's sixth sprint and still broken on ASAN. can you please address this ASAP or just revert jonathan's commit from May? it's unfair to the build barons to have to keep dealing with this. |