[SERVER-35100] Do not log a Python stack trace when a hook dynamic test fails Created: 18/May/18  Updated: 29/Oct/23  Resolved: 05/Jun/18

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 3.4.17, 3.6.8, 4.0.2, 4.1.1

Type: Improvement Priority: Major - P3
Reporter: Yves Duhem Assignee: Yves Duhem
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.0, v3.6, v3.4, v3.2
Sprint: TIG 2018-06-18
Participants:
Story Points: 1

 Description   

Currently, when a dynamic test (run in a hook) fails, the exception that was thrown gets logged.

The stack trace in the logs is unrelated to the cause of the failure and only adds noise. It should be removed. The log statement is here.



 Comments   
Comment by Githook User [ 23/Aug/18 ]

Author:

{'name': 'Yves Duhem', 'email': 'yves.duhem@mongodb.com', 'username': 'syev'}

Message: SERVER-35100 Do not log exception on dynamic test failure
Branch: v3.4
https://github.com/mongodb/mongo/commit/8c8dca466b256155b9f4d93858f432998cd6de12

Comment by Githook User [ 23/Aug/18 ]

Author:

{'name': 'Yves Duhem', 'email': 'yves.duhem@mongodb.com', 'username': 'syev'}

Message: SERVER-35100 Do not log exception on dynamic test failure
Branch: v3.6
https://github.com/mongodb/mongo/commit/14681d89a9093802a8b29455c8a361ccd36b42c9

Comment by Githook User [ 23/Aug/18 ]

Author:

{'name': 'Yves Duhem', 'email': 'yves.duhem@mongodb.com', 'username': 'syev'}

Message: SERVER-35100 Do not log exception on dynamic test failure

(cherry picked from commit bc2902cbf59d877253ce6eb94451515aa1e47062)
Branch: v4.0
https://github.com/mongodb/mongo/commit/aaaa75a5912a8b5fc1c9fbd7ee5505c83b060017

Comment by Githook User [ 05/Jun/18 ]

Author:

{'username': 'syev', 'name': 'Yves Duhem', 'email': 'yves.duhem@mongodb.com'}

Message: SERVER-35100 Do not log exception on dynamic test failure
Branch: master
https://github.com/mongodb/mongo/commit/bc2902cbf59d877253ce6eb94451515aa1e47062

Comment by Max Hirschhorn [ 26/May/18 ]

From our triage meeting, it sounds like we just want to change .exception() to .error().

https://docs.python.org/2/library/logging.html#logging.Logger.debug

Generated at Thu Feb 08 04:38:49 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.