[SERVER-35144] Don't exit immediately if Python linter sees an error Created: 22/May/18 Updated: 29/Oct/23 Resolved: 04/Jun/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Testing Infrastructure |
| Affects Version/s: | 3.7.9 |
| Fix Version/s: | 4.0.0-rc2, 4.1.1 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Robert Guo (Inactive) | Assignee: | Robert Guo (Inactive) |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Backport Requested: |
v4.0, v3.6
|
||||
| Sprint: | TIG 2018-06-18 | ||||
| Participants: | |||||
| Description |
|
The Python linter should run to the end so all the errors show up at once, otherwise the user has to rerun the linter(s) multiple times to fix all the problems, which takes up more time. |
| Comments |
| Comment by Githook User [ 04/Jun/18 ] |
|
Author: {'username': 'guoyr', 'name': 'Robert Guo', 'email': 'robert.guo@10gen.com'}Message: (cherry picked from commit 8309ad48487cb0529fc2153b5231f61e9a597db6) |
| Comment by Githook User [ 04/Jun/18 ] |
|
Author: {'username': 'guoyr', 'name': 'Robert Guo', 'email': 'robert.guo@10gen.com'}Message: |
| Comment by Robert Guo (Inactive) [ 22/May/18 ] |
|
max.hirschhorn It's specific to the Python linters because we run more than one linter. This for loop does not exist in the other linters, so there's no concern of erroring out early. |
| Comment by Max Hirschhorn [ 22/May/18 ] |
|
robert.guo, is the early exit behavior something specific to the Python linter or something that is common to all of the linters? |