[SERVER-35160] ScopedThreads should automatically inherit TestData from their parent thread Created: 22/May/18 Updated: 29/Oct/23 Resolved: 11/Sep/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Shell, Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | 4.1.3 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Spencer Brody (Inactive) | Assignee: | Jonathan Abrahams |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | tig-qwin-eligible | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | TIG 2018-09-10 | ||||||||
| Participants: | |||||||||
| Story Points: | 2 | ||||||||
| Description |
|
For a test that uses ScopedThread to pass in the auth passthrough tests, the test author needs to remember to manually pass TestData into the spawned thread so it can inherit the proper auth credentials. startParallelShell automatically copies the TestData to the new shell, ScopedThread should behave the same. |
| Comments |
| Comment by Githook User [ 11/Sep/18 ] | ||||||||||||||||||
|
Author: {'name': 'Max Hirschhorn', 'email': 'max.hirschhorn@mongodb.com', 'username': 'visemet'}Message: The global TestData object is `undefined` when the backup_restore*.js This partially reverts some of the changes to worker_thread.js from | ||||||||||||||||||
| Comment by Max Hirschhorn [ 10/Sep/18 ] | ||||||||||||||||||
|
I'm reopening this ticket because milkie has pointed out that the worker threads started by the concurrency framework are failing due to the global TestData object being undefined. The "Too many worker threads failed to spawn - aborting" exception gets swallowed because it isn't a TypeError or ReferenceError.
| ||||||||||||||||||
| Comment by Githook User [ 05/Sep/18 ] | ||||||||||||||||||
|
Author: {'name': 'Jonathan Abrahams', 'email': 'jonathan@mongodb.com', 'username': 'hptabster'}Message: | ||||||||||||||||||
| Comment by Spencer Brody (Inactive) [ 22/May/18 ] | ||||||||||||||||||
|
If this worked it would have avoided the need for this hotfix to unbreak the build: https://github.com/mongodb/mongo/commit/abb1b353648260175c3dfe02ac8ae54c083956f7 |