[SERVER-35181] MongoDB 4.0 does not build with --use-cpu-profiler Created: 23/May/18  Updated: 29/Oct/23  Resolved: 04/Jun/18

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: 4.0.0-rc0
Fix Version/s: 4.0.0, 4.1.1

Type: Bug Priority: Major - P3
Reporter: David Bartley Assignee: Benjamin Caimano (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Problem/Incident
Related
is related to SERVER-33261 jstests/core/views/views_all_commands... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.0
Steps To Reproduce:

sconsĀ --use-cpu-profiler all

Sprint: Platforms 2018-06-04, Platforms 2018-06-18
Participants:
Linked BF Score: 0

 Description   

A couple issues in src/mongo/db/commands/cpuprofile.cpp:

  • secondaryAllowed should have a ServiceContext* argument
  • addRequiredPrivileges should be marked as const, not override

I imagine this is also broken in master, though I did not check.



 Comments   
Comment by Githook User [ 05/Jun/18 ]

Author:

{'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}

Message: SERVER-35181 Corrected function signatures for CpuProfilerCommand

Note that this also adds a RHEL 7.0 variant specifically for Dagger
and gperftools
Branch: v4.0
https://github.com/mongodb/mongo/commit/51e7f0341bb9aab72bfc883822df31dcb0bafa47

Comment by Benjamin Caimano (Inactive) [ 04/Jun/18 ]

I wasn't sure how to do that, the correction is appreciated!

Comment by Benjamin Caimano (Inactive) [ 04/Jun/18 ]

I've added a new evergreen variant that will be red until we get new rhel 7.0 images. That said, this should be fixed now in master.

Comment by Benjamin Caimano (Inactive) [ 29/May/18 ]

bartle, yeah, I think it would. Thanks for bringing that to my attention!

Comment by David Bartley [ 29/May/18 ]

I think that'd also resolve SERVER-33261?

Comment by Benjamin Caimano (Inactive) [ 29/May/18 ]

Pushed into master to make available for the new audit perf epic, I'll close out the ticket once the new variant has its new image.

Comment by Githook User [ 29/May/18 ]

Author:

{'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}

Message: SERVER-35181 Corrected function signatures for CpuProfilerCommand

Note that this also adds a RHEL 7.0 variant specifically for Dagger
and gperftools
Branch: master
https://github.com/mongodb/mongo/commit/c30e4d2225120479077e8a78f3648d284215d9aa

Comment by David Bartley [ 23/May/18 ]

It would be nice if there was an evergreen target that at least built with --use-cpu-profiler, since presumably that would have caught this.

Generated at Thu Feb 08 04:39:04 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.