[SERVER-352] Missing include in engine_spidermonkey.h when using the latest spidermonkey ? Created: 10/Oct/09  Updated: 12/Jul/16  Resolved: 10/Oct/09

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: 1.1.2
Fix Version/s: 1.1.2

Type: Bug Priority: Major - P3
Reporter: metagoto Assignee: Eliot Horowitz (Inactive)
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

OS X 10.6 x86_64


Participants:

 Description   

I am using the latest spidermonkey sources from http://hg.mozilla.org/mozilla-central
spidermonkey is built without any problems (JS_VERSION == 180) which makes me think it is not a spidermonkey bug.

Anyway, while building MongoDB, I encountered this error when generating engine_spidermonkey.o :


In file included from scripting/engine_spidermonkey.h:37,
from scripting/engine_spidermonkey.cpp:4:
/Users/runpac/dev/spidermonkey_release/include/js/jsregexp.h:188: error: 'JSSLOT_PRIVATE' was not declared in this scope
/Users/runpac/dev/spidermonkey_release/include/js/jsregexp.h: In function 'void js_ClearRegExpLastIndex(JSObject*)':
/Users/runpac/dev/spidermonkey_release/include/js/jsregexp.h:195: error: invalid use of incomplete type 'struct JSObject'
/Users/runpac/dev/spidermonkey_release/include/js/jspubtd.h:144: error: forward declaration of 'struct JSObject'

js/jsregexp.h included from engine_spidermonkey.h is missing a few symbols located in js/jsobj.h

I managed to compile everything with this simple fix:

diff --git a/scripting/engine_spidermonkey.h b/scripting/engine_spidermonkey.h
index 46ac71a..6799b99 100644
— a/scripting/engine_spidermonkey.h
+++ b/scripting/engine_spidermonkey.h
@@ -34,6 +34,7 @@

#include "js/jsapi.h"
#include "js/jsdate.h"
+#include "js/jsobj.h"
#include "js/jsregexp.h"

#endif



 Comments   
Comment by Eliot Horowitz (Inactive) [ 16/Oct/09 ]

release 10/16/2009

Generated at Thu Feb 08 02:53:48 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.