[SERVER-35225] retryOnNetworkErrors does not subtract from number of retries Created: 25/May/18  Updated: 20/Jun/18  Resolved: 09/Jun/18

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: Judah Schvimer Assignee: Max Hirschhorn
Resolution: Duplicate Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
duplicates SERVER-34666 Reduce the number of retries needed f... Backlog
Related
Operating System: ALL
Participants:
Linked BF Score: 22

 Description   

The number of retries is not decremented when any of the "continue" lines are hit: https://github.com/mongodb/mongo/blob/dea326f41fbca28ca83f881bff1591b0f95ed645/jstests/libs/override_methods/auto_retry_on_network_error.js#L348



 Comments   
Comment by Max Hirschhorn [ 09/Jun/18 ]

I'm going to close this ticket as a duplicate of SERVER-34666 because they'll achieve the same effect (or discover a new reason we need more retries). Feel free to reopen this ticket if either of you disagree.

Comment by Jack Mulrow [ 31/May/18 ]

max.hirschhorn I can't remember exactly, but I think we were seeing cases where the shell could exhaust its retries getting stepdown related errors that didn't force it to retarget the primary. I think using _markHostAsFailed() like in SERVER-34665 to force retargets should work.

Comment by Max Hirschhorn [ 25/May/18 ]

jack.mulrow, do you recall why numRetries wasn't being decremented in the auto_retry_on_network_error.js override file? Do you think that we could instead use the Mongo.prototype._markHostAsFailed() from SERVER-34665 to force the mongo shell to retarget the retry attempt?

Generated at Thu Feb 08 04:39:13 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.