[SERVER-35231] Invalid decimal continuation can trigger a dassert when decoding a KeyString Created: 25/May/18 Updated: 29/Oct/23 Resolved: 29/May/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 3.6.6, 4.0.0, 4.1.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Nicholas Zolnierz | Assignee: | Nicholas Zolnierz |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Backport Requested: |
v4.0, v3.6
|
||||||||
| Sprint: | Query 2018-06-04 | ||||||||
| Participants: | |||||||||
| Linked BF Score: | 61 | ||||||||
| Description |
|
Found from the randomized key string decode test in the linked BF, we attempt to construct an invalid Decimal128 here. The fix is trivial, just need to add a 'Decimal128::isValid()' check before constructing. |
| Comments |
| Comment by Githook User [ 05/Jun/18 ] |
|
Author: {'username': 'nzolnierzmdb', 'name': 'Nick Zolnierz', 'email': 'nicholas.zolnierz@mongodb.com'}Message: (cherry picked from commit 6865427f4a129fed40d7cba730b3cdb33b82d254) |
| Comment by Githook User [ 05/Jun/18 ] |
|
Author: {'username': 'nzolnierzmdb', 'name': 'Nick Zolnierz', 'email': 'nicholas.zolnierz@mongodb.com'}Message: (cherry picked from commit 6865427f4a129fed40d7cba730b3cdb33b82d254) |
| Comment by David Storch [ 05/Jun/18 ] |
|
nicholas.zolnierz, yep, I've approved backports to both the 4.0 and 3.6 branches. |
| Comment by Nicholas Zolnierz [ 04/Jun/18 ] |
|
david.storch This BF has happened twice on the 3.6 branch in the last week, and the backport is trivial. We missed it in the triage meeting but I think we should do it. Do you agree? |
| Comment by Githook User [ 29/May/18 ] |
|
Author: {'username': 'nzolnierzmdb', 'name': 'Nick Zolnierz', 'email': 'nicholas.zolnierz@mongodb.com'}Message: |