[SERVER-35311] Add teardown environment to system_perf.yml in post task for initial sync logkeeper. Created: 31/May/18  Updated: 13/Nov/18  Resolved: 08/Jun/18

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: David Daly Assignee: Henrik Ingo (Inactive)
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
Sprint: Performance 2018-06-04, Performance 2018-06-18
Participants:
Story Points: 2

 Description   
  • Add a teardown function, similar to used in longevity. 
  • Call it after running the tests for initial sync logkeeper
  • Call it in the post phase for initial sync logkeeper

See this code in longevity.yml



 Comments   
Comment by Henrik Ingo (Inactive) [ 08/Jun/18 ]

So, worst case today we should hold onto the cluster for an extra hour, or possibly reuse it if another cluster is waiting. That's not awful.

It's also exactly what we do for every other variant. Why should this be different? (Note that I think the original reason to file this ticket was to prevent reusing the logkeeper cluster, and it turns out that was fixed last year.)

The mark idle shouldn't be called if /data/infrastructure_provisioning/terraform/provisioned.${cluster} doesn't exist. It looks like we should handle that in infrastructure_teardown.py, but don't. Would it work if we called infrastructure_teardown in the /data/infrastructure_provisioning directory, instead of ${work}?

Good point. infrastructure_teardown.py should clean up regardless of where it is called (when bootstrap.production=True) but apparently doesn't. Until now it hasn't been needed. In any case, I don't see that as in scope for this ticket.

We could just close as won't fix also.

Ok, I will.

Generated at Thu Feb 08 04:39:27 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.