[SERVER-35366] Oplog applier batch size should never be less than 16MB Created: 01/Jun/18 Updated: 29/Oct/23 Resolved: 05/Jun/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 4.0.0, 4.1.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Judah Schvimer | Assignee: | Judah Schvimer |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Backport Requested: |
v4.0
|
||||||||
| Sprint: | Repl 2018-06-18 | ||||||||
| Participants: | |||||||||
| Linked BF Score: | 71 | ||||||||
| Description |
|
Here is where we calculate the batch size. |
| Comments |
| Comment by Githook User [ 05/Jun/18 ] |
|
Author: {'username': 'judahschvimer', 'name': 'Judah Schvimer', 'email': 'judah@mongodb.com'}Message: (cherry picked from commit 9d000b9eced82065afaa4a64c227930da0d70206) |
| Comment by Githook User [ 05/Jun/18 ] |
|
Author: {'username': 'judahschvimer', 'name': 'Judah Schvimer', 'email': 'judah@mongodb.com'}Message: |
| Comment by Spencer Brody (Inactive) [ 01/Jun/18 ] |
|
Another approach would be to keep the batch size limit calculation the same, but ensure that every batch always has at least 1 op. I don't think we care very much about the use case of nodes with oplogs smaller than 160MB, however, so the simpler fix of just making sure the batch size limit is always at least 16MB seems like a fine approach. |
| Comment by Judah Schvimer [ 01/Jun/18 ] |
|
The batch size is checked in the oplog applier here. It's not set on the cursor. |