[SERVER-35442] stepdown global lock acqusition should use wait time, not freeze time Created: 06/Jun/18 Updated: 29/Oct/23 Resolved: 23/Jul/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 4.0.2, 4.1.2 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Eric Milkie | Assignee: | Vesselina Ratcheva (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Operating System: | ALL | ||||
| Backport Requested: |
v4.0
|
||||
| Sprint: | Repl 2018-07-16, Repl 2018-07-30 | ||||
| Participants: | |||||
| Description |
|
When we added interruptibility to lock acquisitions, we chose the "stepDownUntil" deadline for the global lock acquisition timeout in ReplicationCoordinatorImpl::stepDown(). This unfortunately-named variable is actually the freeze time, which dictates how long a node will wait before attempting to become primary again, after the stepdown has finished and the function has returned. This function is used by both the replicaSetStepDown and shutdown commands, and so this bug affects both. |
| Comments |
| Comment by Githook User [ 04/Aug/18 ] |
|
Author: {'username': 'vessy-mongodb', 'name': 'Vesselina Ratcheva', 'email': 'vesselina.ratcheva@10gen.com'}Message: (cherry picked from commit ac93e387d998d28e493857a1eebb8a044738bbc0) |
| Comment by Githook User [ 23/Jul/18 ] |
|
Author: {'username': 'vessy-mongodb', 'name': 'Vesselina Ratcheva', 'email': 'vesselina.ratcheva@10gen.com'}Message: |
| Comment by Eric Milkie [ 28/Jun/18 ] |
|
This problem exists in older branches than 4.0, but I don't see it as super critical to backport a fix there. |