[SERVER-35455] QueryPlannerAccess should hold owned pointers by unique_ptr rather than raw pointer Created: 06/Jun/18 Updated: 29/Oct/23 Resolved: 12/Jun/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Querying |
| Affects Version/s: | None |
| Fix Version/s: | 3.4.19, 3.6.10, 4.0.6, 4.1.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | David Storch | Assignee: | David Storch |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||||||
| Backport Requested: |
v4.0, v3.6, v3.4
|
||||||||||||||||||||||||
| Sprint: | Query 2018-06-18 | ||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||
| Case: | (copied to CRM) | ||||||||||||||||||||||||
| Linked BF Score: | 15 | ||||||||||||||||||||||||
| Description |
|
planner_access.cpp has quite a few uses of owned raw pointers which need to be cleaned up. This code is not exception safe, and our testing infrastructure has proven that it can leak memory in obscure error cases. Furthermore, implementation errors in the planner that would lead to query-fatal exceptions have the additional adverse consequence of leaking memory. Finally, fixing this will make it easier to move towards having the planner propagate errors by exception instead of Status. |
| Comments |
| Comment by Githook User [ 20/Dec/18 ] |
|
Author: {'username': 'cswanson310', 'email': 'charlie.swanson@mongodb.com', 'name': 'Charlie Swanson'}Message: (cherry picked from commit 5b736830826eca2cc36f4c6e2ebbcaf524e9c5e0) |
| Comment by Githook User [ 20/Dec/18 ] |
|
Author: {'username': 'dstorch', 'email': 'david.storch@10gen.com', 'name': 'David Storch'}Message: This fixes a previous version of this commit by adding (cherry picked from commit 1d89d2c88bcb39045701b87612b866ae2eb49378) |
| Comment by Githook User [ 20/Dec/18 ] |
|
Author: {'username': 'cswanson310', 'email': 'charlie.swanson@mongodb.com', 'name': 'Charlie Swanson'}Message: Targeted fix for reproduction script for The patch for |
| Comment by Githook User [ 20/Dec/18 ] |
|
Author: {'username': 'cswanson310', 'email': 'charlie.swanson@mongodb.com', 'name': 'Charlie Swanson'}Message: (cherry picked from commit 5b736830826eca2cc36f4c6e2ebbcaf524e9c5e0) |
| Comment by Githook User [ 18/Dec/18 ] |
|
Author: {'username': 'cswanson310', 'email': 'charlie.swanson@mongodb.com', 'name': 'Charlie Swanson'}Message: (cherry picked from commit 5b736830826eca2cc36f4c6e2ebbcaf524e9c5e0) |
| Comment by Githook User [ 18/Dec/18 ] |
|
Author: {'username': 'dstorch', 'email': 'david.storch@10gen.com', 'name': 'David Storch'}Message: This fixes a previous version of this commit by adding (cherry picked from commit 1d89d2c88bcb39045701b87612b866ae2eb49378) |
| Comment by Githook User [ 14/Dec/18 ] |
|
Author: {'username': 'cswanson310', 'email': 'charlie.swanson@mongodb.com', 'name': 'Charlie Swanson'}Message: |
| Comment by Githook User [ 12/Jun/18 ] |
|
Author: {'username': 'dstorch', 'name': 'David Storch', 'email': 'david.storch@10gen.com'}Message: This fixes a previous version of this commit by adding |
| Comment by Githook User [ 12/Jun/18 ] |
|
Author: {'username': 'dstorch', 'name': 'David Storch', 'email': 'david.storch@10gen.com'}Message: Revert " This reverts commit dd1a525f1d1b9e3cf8f902d6c04a17607d565dea. |
| Comment by Githook User [ 11/Jun/18 ] |
|
Author: {'username': 'dstorch', 'name': 'David Storch', 'email': 'david.storch@10gen.com'}Message: |