[SERVER-35512] QuerySolutionNode should hold its children by unique_ptr Created: 08/Jun/18  Updated: 29/Oct/23  Resolved: 18/Apr/22

Status: Closed
Project: Core Server
Component/s: Querying
Affects Version/s: None
Fix Version/s: 6.1.0-rc0

Type: Improvement Priority: Major - P3
Reporter: David Storch Assignee: David Percy
Resolution: Fixed Votes: 1
Labels: storch
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by SERVER-59224 Remove more owned raw pointers from Q... Closed
Related
related to SERVER-35515 MatchExpression trees should hold chi... Closed
related to SERVER-59224 Remove more owned raw pointers from Q... Closed
is related to SERVER-35455 QueryPlannerAccess should hold owned ... Closed
Backwards Compatibility: Fully Compatible
Sprint: QO 2022-04-18, QO 2022-05-02
Participants:
Linked BF Score: 72

 Description   

Right now, it holds its children as a vector of owned raw pointers, despite unique ownership semantics:

https://github.com/mongodb/mongo/blob/1c9354d71c835820f46e5cc557e604b1d602debd/src/mongo/db/query/query_solution.h#L147-L148



 Comments   
Comment by Githook User [ 18/Apr/22 ]

Author:

{'name': 'David Percy', 'email': 'david.percy@mongodb.com', 'username': 'dpercy'}

Message: SERVER-35512 Use unique_ptr in QuerySolutionNode::children and clone()
Branch: master
https://github.com/mongodb/mongo/commit/3197971a3b481538c485c40f77199f7780747613

Generated at Thu Feb 08 04:40:03 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.