[SERVER-35552] Use proper FCV checking when _configsvrAddShard sends new _addShard command Created: 12/Jun/18  Updated: 29/Oct/23  Resolved: 26/Jul/18

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 4.1.2

Type: Task Priority: Major - P3
Reporter: Matthew Saltz (Inactive) Assignee: Matthew Saltz (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Sharding 2018-07-16, Sharding 2018-07-30
Participants:

 Description   

Currently, to make a new replica set shard-aware, during addShard the config server will insert a shard identity document into the new replica set, which triggers shard initialization. SERVER-35486 changes that, so that it instead issues a newly defined _addShard command that will run on the replica set. However, in mixed-version clusters (and therefore in multiversion tests), the _addShard command won't exist on some shards. Therefore, _configsvrAddShard needs to handle the case where the cluster is not fully upgraded. This should be done with proper FCV checking, but since this is not yet available for 4.2, it is currently being done by simply checking if _addShard returns CommandNotFound, and then retrying with a direct insert. Once FCV checking is in place for 4.2, we should change this behavior to use the proper procedure.



 Comments   
Comment by Githook User [ 26/Jul/18 ]

Author:

{'name': 'Matthew Saltz', 'email': 'matthew.saltz@mongodb.com'}

Message: SERVER-35552 Use proper FCV checking when _configsvrAddShard sends new _addShard command
Branch: master
https://github.com/mongodb/mongo/commit/58fcc7b5280cbe14a15a58fceaaf9d0ce8418434

Comment by Blake Oler [ 02/Jul/18 ]

This is good to begin matthew.saltz

Generated at Thu Feb 08 04:40:12 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.