[SERVER-35559] Update transaction retry functions to not call abort after commit Created: 12/Jun/18  Updated: 29/Oct/23  Resolved: 26/Jun/18

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: 4.1.1
Fix Version/s: 4.0.2, 4.1.1

Type: Task Priority: Major - P3
Reporter: Robert Guo (Inactive) Assignee: Jonathan Abrahams
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Related
related to SERVER-35262 Add concurrency_simultaneous_replicat... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.0
Sprint: TIG 2018-07-02
Participants:
Story Points: 2

 Description   

After the changes in SERVER-35094 to disallow calling abortTransaction() after commitTransaction() The withTxnAndAutoRetry helper function and retry logic in the background dbhash hook will need to be changed to not call abortTransaction() if the failure error comes from commitTransaction()



 Comments   
Comment by Githook User [ 03/Aug/18 ]

Author:

{'name': 'Jonathan Abrahams', 'email': 'jonathan@mongodb.com', 'username': 'hptabster'}

Message: SERVER-35559 Correct logic in auto_retry_transaction.js

(cherry picked from commit 7795f9ac84cbb2af05f1e058d0e6b1de05601b26)
Branch: v4.0
https://github.com/mongodb/mongo/commit/76cfb67c42922a4ea6631ea36d0e3e2b456b39b4

Comment by Githook User [ 03/Aug/18 ]

Author:

{'name': 'Jonathan Abrahams', 'email': 'jonathan@mongodb.com', 'username': 'hptabster'}

Message: SERVER-35559 Update transaction retry functions to not call abort after commit

(cherry picked from commit b2cbb83011c68aa44242bc4737cca1e6951e8796)
Branch: v4.0
https://github.com/mongodb/mongo/commit/4a45ba9484a79789265eb30f422e612078f54803

Comment by Githook User [ 26/Jun/18 ]

Author:

{'username': 'hptabster', 'name': 'Jonathan Abrahams', 'email': 'jonathan@mongodb.com'}

Message: SERVER-35559 Correct logic in auto_retry_transaction.js
Branch: master
https://github.com/mongodb/mongo/commit/7795f9ac84cbb2af05f1e058d0e6b1de05601b26

Comment by Githook User [ 26/Jun/18 ]

Author:

{'username': 'hptabster', 'name': 'Jonathan Abrahams', 'email': 'jonathan@mongodb.com'}

Message: SERVER-35559 Update transaction retry functions to not call abort after commit
Branch: master
https://github.com/mongodb/mongo/commit/b2cbb83011c68aa44242bc4737cca1e6951e8796

Comment by Jonathan Abrahams [ 13/Jun/18 ]

The work for SERVER-35262 has logic to call runCommand with abortTransaction, and ignore any responses, so it is not dependent on it. The work in this ticket may not required for some of the workloads.

Comment by Max Hirschhorn [ 13/Jun/18 ]

robert.guo, jonathan.abrahams, SERVER-35262 is marked as depending on this ticket but this ticket isn't assigned to a human nor is it scheduled until the next sprint. What's going on?

Generated at Thu Feb 08 04:40:13 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.