[SERVER-35570] Improve robustness of backup_restore.js around dropping test database Created: 12/Jun/18  Updated: 29/Oct/23  Resolved: 26/Sep/18

Status: Closed
Project: Core Server
Component/s: Replication, Testing Infrastructure
Affects Version/s: None
Fix Version/s: 3.6.9, 4.0.4, 4.1.4

Type: Bug Priority: Major - P3
Reporter: Vesselina Ratcheva (Inactive) Assignee: Vesselina Ratcheva (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.0, v3.6
Sprint: Repl 2018-07-30, Repl 2018-08-13, Repl 2018-08-27, Repl 2018-09-10, Repl 2018-09-24, Repl 2018-10-08
Participants:
Linked BF Score: 16

 Description   

The backup-restore fixture may kill its FSM client while the latter is in the process of dropping the test database as part of its per-workload cleanup. In that case, that fixture could later fail to write to that database, as it may be in a drop-pending state. The following improvements can be made to avoid this scenario:
1. Use an assert.soon to poll for the test database to no longer exist right after killing the FSM and CRUD clients. (We currently all ReplSetTest.awaitReplication(), which is not sufficient in this case, since the drop database oplog entry may not exist yet).
2. The backup-restore fixture attempts to ensure replication between workloads by doing a w:3 insert on the test.fsm_teardown collection and then immediately dropping it. It would be more useful to change the write concern to w:majority so that we can be sure it gets committed.



 Comments   
Comment by Githook User [ 25/Oct/18 ]

Author:

{'name': 'Vesselina Ratcheva', 'email': 'vesselina.ratcheva@10gen.com', 'username': 'vessy-mongodb'}

Message: SERVER-35570 Improve robustness of backup_restore.js around dropping test database

(cherry picked from commit 729a923ea4e0ba5518afb2efb0133aa5f5194391)
Branch: v3.6
https://github.com/mongodb/mongo/commit/1b8632701dc4c55dabee97cf39b5c1c018712541

Comment by Githook User [ 25/Oct/18 ]

Author:

{'name': 'Vesselina Ratcheva', 'email': 'vesselina.ratcheva@10gen.com', 'username': 'vessy-mongodb'}

Message: SERVER-35570 Improve robustness of backup_restore.js around dropping test database

(cherry picked from commit 729a923ea4e0ba5518afb2efb0133aa5f5194391)
Branch: v4.0
https://github.com/mongodb/mongo/commit/a0042dc2e3a440e0787fe8bb95bb99308ea36516

Comment by Githook User [ 26/Sep/18 ]

Author:

{'name': 'Vesselina Ratcheva', 'email': 'vesselina.ratcheva@10gen.com', 'username': 'vessy-mongodb'}

Message: SERVER-35570 Improve robustness of backup_restore.js around dropping test database
Branch: master
https://github.com/mongodb/mongo/commit/729a923ea4e0ba5518afb2efb0133aa5f5194391

Generated at Thu Feb 08 04:40:15 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.