[SERVER-35572] Always allow log archiving in WiredTiger Created: 13/Jun/18 Updated: 29/Oct/23 Resolved: 15/Jun/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Storage, WiredTiger |
| Affects Version/s: | None |
| Fix Version/s: | 4.0.0-rc6, 4.1.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Alexander Gorrod | Assignee: | Daniel Gottlieb (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Operating System: | ALL | ||||||||||||||||
| Backport Requested: |
v4.0
|
||||||||||||||||
| Sprint: | Storage NYC 2018-06-18 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Description |
|
The code handling clean shutdown with a version downgrade currently disables log archiving in WiredTiger - that causes WiredTiger to leave log files present in multiple different formats, which will lead to issues in terms of checking version compatibility when starting up databases with earlier versions of MongoDB. The particular code in question is in WiredTigerKVEngine::cleanShutdown The archive=false setting has been passed since the code was added. There was a conversation in the code review process, which indicates that was done to enable manual checking during development. I think it's better to allow WiredTiger to remove the previous version log files when downgrading, so the downgrade can leave a database in a fully downgraded state. |
| Comments |
| Comment by Githook User [ 15/Jun/18 ] |
|
Author: {'username': 'dgottlieb', 'name': 'Daniel Gottlieb', 'email': 'daniel.gottlieb@mongodb.com'}Message: (cherry picked from commit e08d0f6b6978bbdfa7f4e6fae5beb6df74b78433) |
| Comment by Githook User [ 15/Jun/18 ] |
|
Author: {'username': 'dgottlieb', 'name': 'Daniel Gottlieb', 'email': 'daniel.gottlieb@mongodb.com'}Message: |
| Comment by Alexander Gorrod [ 13/Jun/18 ] |
|
daniel.gottlieb would you mind shepherding this simple change in, if you agree with it? |
| Comment by Alexander Gorrod [ 13/Jun/18 ] |
|
The conversation from the code review was:
I believe that having co-existing versions is a problem, in that it will leave content that is newer than would be accessible using an older version of MongoDB. |