[SERVER-35615] AsyncDBClient should parse isMaster response before calling validateHost Created: 15/Jun/18  Updated: 29/Oct/23  Resolved: 15/Jun/18

Status: Closed
Project: Core Server
Component/s: Networking
Affects Version/s: 4.0.0-rc5, 4.1.1
Fix Version/s: 4.0.0-rc6, 4.1.1

Type: Bug Priority: Major - P3
Reporter: Matthew Saltz (Inactive) Assignee: Jonathan Reams
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.0
Sprint: Platforms 2018-06-18
Participants:
Linked BF Score: 0

 Description   

In version 3.6, responses to isMaster would be first parsed and checked for errors, then sent to the hook for validation. This means that errors like HostUnreachable would be caught before entering hook->validateHost.

In 4.0, it seems we've inverted this ordering, which is leading to an error "Surprised to discover that X does not believe it is a config server" in step-down tests.

We should fix the ordering to be like it was in 3.6.



 Comments   
Comment by Githook User [ 15/Jun/18 ]

Author:

{'username': 'jbreams', 'name': 'Jonathan Reams', 'email': 'jbreams@mongodb.com'}

Message: SERVER-35615 Validate isMaster response before calling validateHost hook

(cherry picked from commit 6c08a0a6455267d215e55838d59cb010dfeaa204)
Branch: v4.0
https://github.com/mongodb/mongo/commit/ecd6d5c33eb562d5a4694699da581852c6d61d93

Comment by Githook User [ 15/Jun/18 ]

Author:

{'username': 'jbreams', 'name': 'Jonathan Reams', 'email': 'jbreams@mongodb.com'}

Message: SERVER-35615 Validate isMaster response before calling validateHost hook
Branch: master
https://github.com/mongodb/mongo/commit/6c08a0a6455267d215e55838d59cb010dfeaa204

Comment by Matthew Saltz (Inactive) [ 15/Jun/18 ]

CC: jonathan.reams

Generated at Thu Feb 08 04:40:24 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.