[SERVER-35684] Remove promise.getFuture() Created: 19/Jun/18 Updated: 29/Oct/23 Resolved: 26/Jul/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | 4.0.2, 4.1.2 |
| Type: | New Feature | Priority: | Major - P3 |
| Reporter: | Mira Carey | Assignee: | ADAM Martin (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Backport Requested: |
v4.0
|
||||
| Sprint: | Platforms 2018-07-16, Platforms 2018-07-30 | ||||
| Participants: | |||||
| Description |
|
promise.getFuture() is racy with setting the promise. Now that we have makePromiseFuture<T>, we should remove the dangerous variant. |
| Comments |
| Comment by Billy Donahue [ 13/Sep/21 ] |
|
I would like to understand what races this was done to avoid. |
| Comment by Githook User [ 17/Aug/18 ] |
|
Author: {'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}Message: Squashed from 3 commits:
This API invites subtle race conditions. So just remove it, and (cherry picked from commit 2338f365430d7f395faf73bff6c64def505da1b3)
(cherry picked from commit b49a27b359b17cd1b1560134b89527b78db565cc)
(cherry picked from commit 5e0545d3625dc85d16f5f021896f61d3a21e2333) |
| Comment by Benjamin Caimano (Inactive) [ 17/Aug/18 ] |
|
Goes in cleanly and it makes things simple for BACKPORT-2316 |
| Comment by Githook User [ 26/Jul/18 ] |
|
Author: {'username': 'adamlsd', 'name': 'ADAM David Alan Martin', 'email': 'adam.martin@10gen.com'}Message: This API invites subtle race conditions. So just remove it, and |