[SERVER-35691] Make all code paths returning StaleConfig error go through the StaleConfigInfo serializer Created: 19/Jun/18  Updated: 29/Oct/23  Resolved: 22/Jun/18

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 4.0.1, 4.1.1

Type: Task Priority: Major - P3
Reporter: Kaloian Manassiev Assignee: Kaloian Manassiev
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
is depended on by SERVER-32198 Missing collection metadata on the sh... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.0
Sprint: Sharding 2018-07-02
Participants:

 Description   

Currently there are code paths, which manually construct the components for the StaleConfigInfo error. Because of this it is difficult to rely on its contents being populated, which leads to code like this. As part of this ticked, all such places should be identified and changed to use the StaleConfigInfo serialization.

In addition, since the stale_config library depends on functionality which happens to be in the headers of common_s, specifically, ChunkVersion. Because of this, it needs to repeat the serialization logic of ChunkVersion. We should merge these two libraries (by folding stale_config into common_s) and should use the ChunkVersion serialization logic for StaleConfigInfo.



 Comments   
Comment by Githook User [ 01/Jul/18 ]

Author:

{'username': 'kaloianm', 'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com'}

Message: SERVER-35691 Make all code paths returning StaleConfig error go through the StaleConfigInfo serializer

(cherry picked from commit d49d27ec475a0c2054c2b5bb2a6b8391b0c30d10)
(cherry picked from commit 5dabb36c0b930f03f8da5cc1b572f3edcf4cff58)
(cherry picked from commit c2a1af025f133c366569448323f1acad3db6f8f7)
(cherry picked from commit e7a75ec01e4e3683cc6b83e3bbc0f4c4b05168dc)
Branch: v4.0
https://github.com/mongodb/mongo/commit/6c89f126439b6c39a659bdfd787041541700b6c3

Comment by Githook User [ 27/Jun/18 ]

Author:

{'username': 'kaloianm', 'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com'}

Message: SERVER-35691 Cleanup StaleConfigInfo serialization
Branch: master
https://github.com/mongodb/mongo/commit/e7a75ec01e4e3683cc6b83e3bbc0f4c4b05168dc

Comment by Githook User [ 22/Jun/18 ]

Author:

{'username': 'kaloianm', 'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com'}

Message: SERVER-35691 Make all code paths returning StaleConfig error go through the StaleConfigInfo serializer
Branch: master
https://github.com/mongodb/mongo/commit/c2a1af025f133c366569448323f1acad3db6f8f7

Comment by Githook User [ 22/Jun/18 ]

Author:

{'username': 'kaloianm', 'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com'}

Message: SERVER-35691 Cleanup the ChunkVersion serialization/deserialization code
Branch: master
https://github.com/mongodb/mongo/commit/5dabb36c0b930f03f8da5cc1b572f3edcf4cff58

Comment by Githook User [ 20/Jun/18 ]

Author:

{'username': 'kaloianm', 'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com'}

Message: SERVER-35691 Merge the stale_config library together with common_s
Branch: master
https://github.com/mongodb/mongo/commit/d49d27ec475a0c2054c2b5bb2a6b8391b0c30d10

Generated at Thu Feb 08 04:40:39 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.