[SERVER-35852] Convert backup_restore.js blacklist to use a YAML based list for transaction tests Created: 27/Jun/18  Updated: 29/Oct/23  Resolved: 12/Oct/18

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: 4.1.1
Fix Version/s: 4.1.5

Type: Improvement Priority: Major - P3
Reporter: Robert Guo (Inactive) Assignee: Jonathan Abrahams
Resolution: Fixed Votes: 0
Labels: tig-qwin-eligible
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Duplicate
is duplicated by SERVER-30002 Clean up backup_restore*.js to run FS... Closed
Problem/Incident
causes SERVER-40518 backup_restore*.js tests send SIGTERM... Closed
Related
related to SERVER-36592 Blacklist snapshot_read_kill_op_only.... Closed
is related to SERVER-35263 Add FSM workloads for testing atomici... Closed
Backwards Compatibility: Fully Compatible
Sprint: TIG 2018-09-24, DAG 2018-10-08, DAG 2018-10-22
Participants:
Linked BF Score: 49
Story Points: 2

 Description   

Having the test understand existing blacklists will reduce the likelihood of a test not being added to the blacklist for backup_restore.js.



 Comments   
Comment by Githook User [ 13/Oct/18 ]

Author:

{'name': 'Max Hirschhorn', 'email': 'max.hirschhorn@mongodb.com', 'username': 'visemet'}

Message: SERVER-35852 Require --shellConnString to use mongodb:// URI scheme.
Branch: master
https://github.com/mongodb/mongo/commit/e5c39e225effd4a28937c32c84ac3dc0c1ceb355

Comment by Githook User [ 12/Oct/18 ]

Author:

{'name': 'Jonathan Abrahams', 'email': 'jonathan@mongodb.com', 'username': 'hptabster'}

Message: SERVER-35852 Convert FSM client to use a resmoke suite for easy test blackisting in backup_restore
Branch: master
https://github.com/mongodb/mongo/commit/b04cc1e53b5d4b13d0b1f25303dd6f33b2e730f8

Comment by Max Hirschhorn [ 18/Sep/18 ]

Max Hirschhorn I am planning to have backup_restore.js invoke resmoke.py to run the FSM client. It will use a ScopedThread to start resmoke and requires a mechanism to stop it when the test completes (as far as I'm aware it would need the PID of the resmoke shell).

jonathan.abrahams, the backup_restore*.js tests should use resmoke.py to run the FSM workloads instead of calling the runWorkloadsSerially() function directly. I don't see a reason you need to use a ScopedThread to run a subprocess from the mongo shell, as that's why functions like runProgram(), etc. exist. The _startMongoProgram() function returns the pid of the subprocess it spawned and you can use stopMongoProgramByPid() to terminate it (you may find you want to use SIGINT rather than SIGTERM).

The CRUD client is already set up in a similar way where it uses the startMongoProgramNoConnect() function to spawn a parallel shell and uses the stopMongoProgramByPid() function to terminate it.

Comment by Jonathan Abrahams [ 18/Sep/18 ]

max.hirschhorn I am planning to have backup_restore.js invoke resmoke.py to run the FSM client. It will use a ScopedThread to start resmoke and requires a mechanism to stop it when the test completes (as far as I'm aware it would need the PID of the resmoke shell).

Please confirm if that's the intent of this ticket.

Generated at Thu Feb 08 04:41:13 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.