[SERVER-35985] sessions_test and sharding_catalog_manager_test don't destroy all Clients before destroying the ServiceContext Created: 06/Jul/18  Updated: 29/Oct/23  Resolved: 06/Jul/18

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 4.0.3, 4.1.1

Type: Bug Priority: Major - P3
Reporter: Max Hirschhorn Assignee: Max Hirschhorn
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Problem/Incident
is caused by SERVER-34798 Replace subclasses of ServiceContext ... Closed
Related
related to SERVER-36400 Explicitly destroy the client on exit... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: TIG 2018-07-16
Participants:
Linked BF Score: 46

 Description   

session_catalog_test.cpp and sharding_catalog_manager_add_shard_test.cpp use Client::initThreadIfNotAlready() in async code but are missing a corresponding ON_BLOCK_EXIT([&] { Client::destroy(); }) which became required as part of SERVER-34798. For reasons that I don't quite understand the _clients.empty() invariant is only triggered on Windows.

    stdx::async(stdx::launch::async, [&] {
        Client::initThreadIfNotAlready();
        auto sideOpCtx = Client::getCurrent()->makeOperationContext();
        auto scopedSession =
            SessionCatalog::get(sideOpCtx.get())->getOrCreateSession(sideOpCtx.get(), lsid);
 
        ASSERT(scopedSession.get());
        ASSERT_EQ(lsid, scopedSession->getSessionId());
    }).get();
 
    ocs.reset();
 
    stdx::async(stdx::launch::async, [&] {
        Client::initThreadIfNotAlready();
        auto sideOpCtx = Client::getCurrent()->makeOperationContext();
        auto scopedSession =
            SessionCatalog::get(sideOpCtx.get())->getOrCreateSession(sideOpCtx.get(), lsid);
 
        ASSERT(scopedSession.get());
        ASSERT_EQ(lsid, scopedSession->getSessionId());
    }).get();

https://github.com/mongodb/mongo/blob/a6e2c10af2dcfa862c6afa0fb1504a5d2b092d09/src/mongo/db/session_catalog_test.cpp#L122-L142
https://github.com/mongodb/mongo/blob/a6e2c10af2dcfa862c6afa0fb1504a5d2b092d09/src/mongo/db/s/config/sharding_catalog_manager_add_shard_test.cpp#L407



 Comments   
Comment by Githook User [ 13/Sep/18 ]

Author:

{'name': 'Henrik Edin', 'email': 'henrik.edin@mongodb.com', 'username': 'henrikedin'}

Message: SERVER-34798 Remove ServiceContext subclasses and use new ServiceContext in every unit test.

This patch does several loosely related and surprisingly hard to separate things.

1.) Make the ServiceContext class final

2.) Create a mechanism, called ConstructorActions, for running methods on
ServiceContexts immediately after they're built and immediately before they're
destroyed.

3.) Introduce / improve test fixture base classes for tests, giving them fresh
ServiceContext instances for each test case. There is one fixture for tests that
need a storage engine and another for those that do not.

4.) Make several remaining global variables SC decorations in support of (3)

5.) Replace many MONGO_INITIALIZERS that access getGlobalServiceContext with the
new constructor-actions system, which is needed for (3.)

6.) Fix up tests to use the fixtures from (3) and fix tests that silently used
different service contexts in together in a technically illegal fashion that now
breaks.

7.) Utilize (2) as necessary to simplify initialization of new ServiceContexts,
simplifying the fixtures in (3).

(cherry picked from commit d520be0814492c262515cf0a5d62a127ace70dce)

SERVER-35985 Destroy clients started in other threads.

(cherry picked from commit 9a68eb0cc65a93233b4ff5746330f9eb77de9b90)

SERVER-36258 Construct ServiceContext after mongo initializers complete.

(cherry picked from commit bfe170e49b1dc10b2badde45bc13c057a2f8ab61)

SERVER-36400 Explicitly destroy the client on exiting run() of each BackgroundJob

(cherry picked from commit b079e4713d897b5541c2804386025817ec720800)

SERVER-36351 Fix so ServiceContextMongoDTest removes the temp directory in its destructor.

(cherry picked from commit 4c16f0f336f4db77034e8aa594bbd4a5bac3f40c)

SERVER-36347 Fix parse_zone_info.py after ServiceContext refactor.

(cherry picked from commit c9d4204b6243e5eee6fe0b5e2c34d02af9ac5edb)
Branch: v4.0
https://github.com/mongodb/mongo/commit/58feaec9c55629ba253b1ff013736eb8b8e9c79d

Comment by Githook User [ 06/Jul/18 ]

Author:

{'username': 'visemet', 'name': 'Max Hirschhorn', 'email': 'max.hirschhorn@mongodb.com'}

Message: SERVER-35985 Destroy clients started in other threads.
Branch: master
https://github.com/mongodb/mongo/commit/9a68eb0cc65a93233b4ff5746330f9eb77de9b90

Generated at Thu Feb 08 04:41:40 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.